[
https://issues.apache.org/jira/browse/HIVE-21529?focusedWorklogId=227450&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-227450
]
ASF GitHub Bot logged work on HIVE-21529:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Apr/19 05:57
Start Date: 15/Apr/19 05:57
Worklog Time Spent: 10m
Work Description: ashutosh-bapat commented on pull request #581:
HIVE-21529 : Bootstrap ACID tables as part of incremental dump.
URL: https://github.com/apache/hive/pull/581#discussion_r275214618
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
##########
@@ -137,17 +137,69 @@ private void prepareReturnValues(List<String> values)
throws SemanticException {
Utils.writeOutput(values, new Path(work.resultTempPath), conf);
}
+ /**
+ * Decide whether to examine all the tables to dump. We do this if
+ * 1. External tables are going to be part of the dump : In which case we
need to list their
+ * locations.
+ * 2. External or ACID tables are being bootstrapped for the first time : so
that we can dump
+ * those tables as a whole.
+ * @return
+ */
+ private boolean shouldDumpExternalTableLocation() {
+ return conf.getBoolVar(HiveConf.ConfVars.REPL_INCLUDE_EXTERNAL_TABLES)
+ && (!conf.getBoolVar(HiveConf.ConfVars.REPL_DUMP_METADATA_ONLY)
+ ||
conf.getBoolVar(HiveConf.ConfVars.REPL_BOOTSTRAP_EXTERNAL_TABLES));
+ }
+
+ private boolean shouldExamineTablesToDump() {
+ return shouldDumpExternalTableLocation() ||
+ conf.getBoolVar(HiveConf.ConfVars.REPL_BOOTSTRAP_ACID_TABLES);
+ }
+
+ private boolean shouldBootstrapDumpTable(Table table) {
+ if (conf.getBoolVar(HiveConf.ConfVars.REPL_BOOTSTRAP_EXTERNAL_TABLES) &&
+ TableType.EXTERNAL_TABLE.equals(table.getTableType())) {
+ return true;
+ }
+
+ if (conf.getBoolVar(HiveConf.ConfVars.REPL_BOOTSTRAP_ACID_TABLES) &&
+ AcidUtils.isTransactionalTable(table)) {
+ return true;
+ }
+
+ return false;
+ }
+
private Long incrementalDump(Path dumpRoot, DumpMetaData dmd, Path cmRoot,
Hive hiveDb) throws Exception {
Long lastReplId;// get list of events matching dbPattern & tblPattern
// go through each event, and dump out each event to a event-level dump
dir inside dumproot
+ ValidTxnList validTxnList = null;
+ long waitUntilTime = 0;
+ long bootDumpBeginReplId = -1;
+
+ // If we are bootstrapping ACID tables, we need to perform steps similar
to a regular
+ // bootstrap (See bootstrapDump() for more details. Only difference here
is instead of
+ // waiting for the concurrent transactions to finish, we start dumping the
incremental events
+ // and wait only for the remaining time if any.
+ if (conf.getBoolVar(HiveConf.ConfVars.REPL_BOOTSTRAP_ACID_TABLES)) {
+ bootDumpBeginReplId =
queryState.getConf().getLong(ReplUtils.LAST_REPL_ID_KEY, -1L);
+ assert (bootDumpBeginReplId >= 0);
+ LOG.info("Dump for bootstrapping ACID tables during an incremental dump
for db {} and table {}",
+ work.dbNameOrPattern,
+ work.tableNameOrPattern);
+ validTxnList = getTxnMgr().getValidTxns();
Review comment:
If we take the snapshot after dumping events, the transactions opened while
dumping events won't get enough time to complete since the waiting time is
reduced by the time taken for dumping events. By taking the transaction
snapshot before dumping events, all the transactions opened then get configured
time to complete. That's why we pass both the snapshot and waiting time reduced
by the event dump time to getValidTxnListForReplDump().
Furthermore this will widen the time gap between noting down the last repl
id and taking the snapshot, thus increasing the chances of hitting the bug we
discussed in earlier round of review comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 227450)
Time Spent: 4h 50m (was: 4h 40m)
> Hive support bootstrap of ACID/MM tables on an existing policy.
> ---------------------------------------------------------------
>
> Key: HIVE-21529
> URL: https://issues.apache.org/jira/browse/HIVE-21529
> Project: Hive
> Issue Type: Sub-task
> Components: repl, Transactions
> Affects Versions: 4.0.0
> Reporter: Sankar Hariappan
> Assignee: Ashutosh Bapat
> Priority: Major
> Labels: DR, pull-request-available, replication
> Attachments: HIVE-21529.01.patch, HIVE-21529.02.patch,
> HIVE-21529.03.patch
>
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> If ACID/MM tables to be enabled (hive.repl.dump.include.acid.tables) on an
> existing repl policy, then need to combine bootstrap dump of these tables
> along with the ongoing incremental dump.
> Shall add a one time config "hive.repl.bootstrap.acid.tables" to include
> bootstrap in the given dump.
> The support for hive.repl.bootstrap.cleanup.type for ACID tables to clean-up
> partially bootstrapped tables in case of retry is already in place, thanks to
> the work done during external tables. Need to test that it actually works.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
