[
https://issues.apache.org/jira/browse/HIVE-21529?focusedWorklogId=227561&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-227561
]
ASF GitHub Bot logged work on HIVE-21529:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Apr/19 09:43
Start Date: 15/Apr/19 09:43
Worklog Time Spent: 10m
Work Description: ashutosh-bapat commented on pull request #581:
HIVE-21529 : Bootstrap ACID tables as part of incremental dump.
URL: https://github.com/apache/hive/pull/581#discussion_r275282557
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/Utils.java
##########
@@ -196,6 +196,23 @@ public static boolean shouldReplicate(ReplicationSpec
replicationSpec, Table tab
}
return shouldReplicateExternalTables;
}
+
+ if (AcidUtils.isTransactionalTable(tableHandle.getTTable())) {
+ // For testing purposes only, do not replicate ACID tables when config
says so
+ boolean shouldReplicateAcidTables = true;
+ if (hiveConf.getBoolVar(HiveConf.ConfVars.HIVE_IN_TEST_REPL)) {
Review comment:
The idea is to use this flag only for testing and not expand its usage
beyond testing. So, as per discussion I have removed this flag from HiveConf
and defined in ReplUtils. We still use HIVE_IN_TEST_REPL to protect dump in
case the user is using REPL_DUMP_INCLUDE_ACID_TABLES in its config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 227561)
Time Spent: 5h 50m (was: 5h 40m)
> Hive support bootstrap of ACID/MM tables on an existing policy.
> ---------------------------------------------------------------
>
> Key: HIVE-21529
> URL: https://issues.apache.org/jira/browse/HIVE-21529
> Project: Hive
> Issue Type: Sub-task
> Components: repl, Transactions
> Affects Versions: 4.0.0
> Reporter: Sankar Hariappan
> Assignee: Ashutosh Bapat
> Priority: Major
> Labels: DR, pull-request-available, replication
> Attachments: HIVE-21529.01.patch, HIVE-21529.02.patch,
> HIVE-21529.03.patch
>
> Time Spent: 5h 50m
> Remaining Estimate: 0h
>
> If ACID/MM tables to be enabled (hive.repl.dump.include.acid.tables) on an
> existing repl policy, then need to combine bootstrap dump of these tables
> along with the ongoing incremental dump.
> Shall add a one time config "hive.repl.bootstrap.acid.tables" to include
> bootstrap in the given dump.
> The support for hive.repl.bootstrap.cleanup.type for ACID tables to clean-up
> partially bootstrapped tables in case of retry is already in place, thanks to
> the work done during external tables. Need to test that it actually works.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
