[
https://issues.apache.org/jira/browse/HIVE-21577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866016#comment-16866016
]
Hive QA commented on HIVE-21577:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m
9s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
14s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
36s{color} | {color:blue} common in master has 62 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
42s{color} | {color:blue} serde in master has 193 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
17s{color} | {color:blue} ql in master has 2255 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
36s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
30s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
46s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
16s{color} | {color:red} common: The patch generated 1 new + 4 unchanged - 0
fixed = 5 total (was 4) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
38s{color} | {color:red} ql generated 23 new + 2233 unchanged - 22 fixed = 2256
total (was 2255) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
34s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 34m 47s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Switch statement found in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.castExpression()
where default case is missing At HiveParser_IdentifiersParser.java:where
default case is missing At HiveParser_IdentifiersParser.java:[lines 3968-3976]
|
| | Dead store to LA31_100 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 33396] |
| | Dead store to LA31_101 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 33409] |
| | Dead store to LA31_102 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 33422] |
| | Dead store to LA31_15 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 33292] |
| | Dead store to LA31_16 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 33305] |
| | Dead store to LA31_17 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 33318] |
| | Dead store to LA31_18 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 33331] |
| | Dead store to LA31_19 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 33344] |
| | Dead store to LA31_97 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 33357] |
| | Dead store to LA31_98 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 33370] |
| | Dead store to LA31_99 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 33383] |
| | Should org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32
be a _static_ inner class? At HiveParser_IdentifiersParser.java:inner class?
At HiveParser_IdentifiersParser.java:[lines 33568-33581] |
| | Dead store to LA36_169 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA36.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA36.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 33868] |
| | Should org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA38
be a _static_ inner class? At HiveParser_IdentifiersParser.java:inner class?
At HiveParser_IdentifiersParser.java:[lines 35078-35091] |
| | Should org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA47
be a _static_ inner class? At HiveParser_IdentifiersParser.java:inner class?
At HiveParser_IdentifiersParser.java:[lines 35999-36012] |
| | Should org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA51
be a _static_ inner class? At HiveParser_IdentifiersParser.java:inner class?
At HiveParser_IdentifiersParser.java:[lines 36488-36501] |
| | Dead store to LA54_48 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 36746] |
| | Dead store to LA54_56 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 36759] |
| | Dead store to LA54_57 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 36772] |
| | Dead store to LA54_58 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 36785] |
| | Dead store to LA54_59 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 36798] |
| | org.apache.hadoop.hive.ql.udf.generic.GenericUDFCastFormat is
Serializable; consider declaring a serialVersionUID At
GenericUDFCastFormat.java:a serialVersionUID At
GenericUDFCastFormat.java:[lines 64-250] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-17615/dev-support/hive-personality.sh
|
| git revision | master / e655579 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17615/yetus/diff-checkstyle-common.txt
|
| whitespace |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17615/yetus/whitespace-eol.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17615/yetus/new-findbugs-ql.html
|
| modules | C: common serde ql U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17615/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Use SQL:2016 patterns for formatting/parsing dates/timestamps by default
> ------------------------------------------------------------------------
>
> Key: HIVE-21577
> URL: https://issues.apache.org/jira/browse/HIVE-21577
> Project: Hive
> Issue Type: Improvement
> Reporter: Karen Coppage
> Assignee: Karen Coppage
> Priority: Major
> Attachments: HIVE-21577
>
>
> Dates and timestamps objects should be parsed and formatted using the
> SQL:2016 formats.
> 1. Formatting
> Date/timestamp casts to string should be:
> * date: yyyy-mm-dd
> * timestamps: yyyy-mm-dd hh24:mi:ss OR yyyy-mm-dd hh24:mi:ss.ff
> 2. Parsing
> Currently accepted timestamp/date formats in Hive 2 and/or Hive 3:
> yyyy-mm-dd
> yyyy-mm-dd hh24:mi ( ? )
> yyyy-mm-dd hh24:mi:ss
> yyyy-mm-dd hh24:mi:ss.ff
> yyyy-mm-dd hh24:mi[space]<timezone>
> yyyy-mm-dd hh24:mi:ss[space]<timezone>
> yyyy-mm-dd hh24:mi:ss.ff[space]<timezone>
> yyyy-mm-ddThh24:mi
> yyyy-mm-ddThh24:mi:ss
> yyyy-mm-ddThh24:mi:ss.ff
> yyyy-mm-ddThh24:miZ
> yyyy-mm-ddThh24:mi:ssZ
> yyyy-mm-ddThh24:mi:ss.ffZ
> The time zone must be valid ( ? ) but is ignored because date/timestamp are
> time zone agnostic (see HIVE-20792)
> yyyy-mm-ddThh24:mi[space]<timezone>
> yyyy-mm-ddThh24:mi:ss[space]<timezone>
> yyyy-mm-ddThh24:mi:ss.ff[space]<timezone>
> Additional parsing requirements:
> * Year 0000 defaults to 0001
> * Out-of-range values are accepted and carried over. E.g. "2019-02-30" parses
> to 2019-03-02.
> 3. If any new formats are accepted with this change, a large number of tests
> will need updating. Some examples: TestTimestampParser, package
> org.apache.hadoop.hive.ql.udf.generic, TestVectorTypeCasts[WithFormat],
> update_all_types.q, TestNegativeCliDriver with date_literal2.q,
> vectorized_timestamp_funcs.q
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
