[ 
https://issues.apache.org/jira/browse/HIVE-21577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866039#comment-16866039
 ] 

Hive QA commented on HIVE-21577:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12971967/HIVE-21577

{color:green}SUCCESS:{color} +1 due to 7 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 51 failed/errored test(s), 16181 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_from_utc_timestamp] 
(batchId=92)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_hour] (batchId=3)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_minute] (batchId=8)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_second] (batchId=32)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[update_all_types] 
(batchId=19)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorized_timestamp_funcs]
 (batchId=33)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_orc_nonvec_part_all_complex]
 (batchId=160)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_orc_nonvec_part_all_complex_llap_io]
 (batchId=183)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_orc_vec_part_all_complex]
 (batchId=174)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_orc_vec_part_all_complex_llap_io]
 (batchId=161)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_nonvec_part_all_complex]
 (batchId=179)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_nonvec_part_all_complex_llap_io]
 (batchId=174)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vec_part_all_complex]
 (batchId=170)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vec_part_all_complex_llap_io]
 (batchId=160)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vecrow_part_all_complex]
 (batchId=183)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vecrow_part_all_complex_llap_io]
 (batchId=179)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[update_all_types]
 (batchId=164)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorized_timestamp_funcs]
 (batchId=168)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[date_literal2] 
(batchId=100)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorized_timestamp_funcs]
 (batchId=126)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testAcidWithSchemaEvolution
 (batchId=336)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testBucketCodec
 (batchId=336)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testBucketizedInputFormat
 (batchId=336)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testCleanerForTxnToWriteId
 (batchId=336)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testCompactWithDelete
 (batchId=336)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testDeleteIn
 (batchId=336)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testDynamicPartitionsMerge
 (batchId=336)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testDynamicPartitionsMerge2
 (batchId=336)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testETLSplitStrategyForACID
 (batchId=336)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testEmptyInTblproperties
 (batchId=336)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testFailHeartbeater
 (batchId=336)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testFileSystemUnCaching
 (batchId=336)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testInitiatorWithMultipleFailedCompactions
 (batchId=336)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testInsertOverwrite1
 (batchId=336)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testInsertOverwrite2
 (batchId=336)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testInsertOverwriteWithSelfJoin
 (batchId=336)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testMerge2
 (batchId=336)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testMerge3
 (batchId=336)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testMergeWithPredicate
 (batchId=336)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testMmTableCompaction
 (batchId=336)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testMultiInsertStatement
 (batchId=336)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testNonAcidInsert
 (batchId=336)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testOpenTxnsCounter
 (batchId=336)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testOrcNoPPD
 (batchId=336)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testOrcPPD
 (batchId=336)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testUpdateMixedCase
 (batchId=336)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.updateDeletePartitioned
 (batchId=336)
org.apache.hadoop.hive.ql.udf.generic.TestGenericUDFAddMonths.testWrongTsStr 
(batchId=304)
org.apache.hadoop.hive.ql.udf.generic.TestGenericUDFNextDay.testNotValidValues 
(batchId=305)
org.apache.hive.common.util.TestTimestampParser.testMillisParser (batchId=297)
org.apache.hive.common.util.TestTimestampParser.testPattern1 (batchId=297)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/17615/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/17615/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-17615/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 51 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12971967 - PreCommit-HIVE-Build

> Use SQL:2016 patterns for formatting/parsing dates/timestamps by default
> ------------------------------------------------------------------------
>
>                 Key: HIVE-21577
>                 URL: https://issues.apache.org/jira/browse/HIVE-21577
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Karen Coppage
>            Assignee: Karen Coppage
>            Priority: Major
>         Attachments: HIVE-21577
>
>
> Dates and timestamps objects should be parsed and formatted using the 
> SQL:2016 formats.
> 1. Formatting
> Date/timestamp casts to string should be:
> * date: yyyy-mm-dd
> * timestamps: yyyy-mm-dd hh24:mi:ss OR yyyy-mm-dd hh24:mi:ss.ff
> 2. Parsing
> Currently accepted timestamp/date formats in Hive 2 and/or Hive 3:
> yyyy-mm-dd
> yyyy-mm-dd hh24:mi ( ? )
> yyyy-mm-dd hh24:mi:ss
> yyyy-mm-dd hh24:mi:ss.ff
> yyyy-mm-dd hh24:mi[space]<timezone>
> yyyy-mm-dd hh24:mi:ss[space]<timezone>
> yyyy-mm-dd hh24:mi:ss.ff[space]<timezone>
> yyyy-mm-ddThh24:mi
> yyyy-mm-ddThh24:mi:ss
> yyyy-mm-ddThh24:mi:ss.ff
> yyyy-mm-ddThh24:miZ
> yyyy-mm-ddThh24:mi:ssZ
> yyyy-mm-ddThh24:mi:ss.ffZ
> The time zone must be valid ( ? ) but is ignored because date/timestamp are 
> time zone agnostic (see HIVE-20792)
> yyyy-mm-ddThh24:mi[space]<timezone>
> yyyy-mm-ddThh24:mi:ss[space]<timezone>
> yyyy-mm-ddThh24:mi:ss.ff[space]<timezone>
> Additional parsing requirements:
> * Year 0000 defaults to 0001
> * Out-of-range values are accepted and carried over. E.g. "2019-02-30" parses 
> to 2019-03-02.
> 3. If any new formats are accepted with this change, a large number of tests 
> will need updating. Some examples: TestTimestampParser, package 
> org.apache.hadoop.hive.ql.udf.generic, TestVectorTypeCasts[WithFormat], 
> update_all_types.q, TestNegativeCliDriver with date_literal2.q, 
> vectorized_timestamp_funcs.q



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to