[ 
https://issues.apache.org/jira/browse/HIVE-22191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16932068#comment-16932068
 ] 

Hive QA commented on HIVE-22191:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12980517/HIVE-22191.2.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 180 failed/errored test(s), 16760 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[ptf_general_queries]
 (batchId=300)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[ptf_orcfile] 
(batchId=300)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[ptf_parquetfile]
 (batchId=300)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[ptf_persistence]
 (batchId=300)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[ptf_rcfile] 
(batchId=300)
org.apache.hadoop.hive.cli.TestBlobstoreCliDriver.testCliDriver[ptf_seqfile] 
(batchId=300)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cbo_windowing] 
(batchId=60)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[correlationoptimizer12] 
(batchId=41)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ctas_colname] 
(batchId=65)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cte_1] (batchId=95)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[distinct_groupby] 
(batchId=47)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[distinct_windowing] 
(batchId=12)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[distinct_windowing_no_cbo]
 (batchId=72)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[groupby_grouping_window] 
(batchId=35)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[leadlag] (batchId=62)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[leadlag_queries] 
(batchId=78)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[localtimezone] 
(batchId=58)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[outer_reference_windowed]
 (batchId=45)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[pcs] (batchId=55)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ppd_windowing1] 
(batchId=49)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ppd_windowing2] 
(batchId=12)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ptf_decimal] (batchId=3)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ptf_general_queries] 
(batchId=7)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ptf_rcfile] (batchId=38)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ptf_seqfile] (batchId=81)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ptfgroupbyjoin] 
(batchId=95)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[quotedid_basic] 
(batchId=67)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[semijoin2] (batchId=60)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[semijoin5] (batchId=17)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[subquery_in_explain_rewrite]
 (batchId=4)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[subquery_unqualcolumnrefs]
 (batchId=20)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[tablevalues] (batchId=75)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[temp_table_windowing_expressions]
 (batchId=70)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[topn] (batchId=50)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udaf_binarysetfunctions] 
(batchId=41)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udaf_binarysetfunctions_no_cbo]
 (batchId=81)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[union36] (batchId=98)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[union_remove_6_subq] 
(batchId=42)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[unionall_lateralview] 
(batchId=17)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[windowing_adjust_rowcontainer_sz]
 (batchId=44)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[windowing_columnPruning] 
(batchId=89)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[windowing_decimal] 
(batchId=75)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[windowing_distinct] 
(batchId=62)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[windowing_duplicate] 
(batchId=34)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[windowing_expressions] 
(batchId=61)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[windowing_gby2] 
(batchId=39)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[windowing_multipartitioning]
 (batchId=61)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[windowing_navfn] 
(batchId=75)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[windowing_ntile] 
(batchId=24)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[windowing_order_null] 
(batchId=60)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[windowing_range_multiorder]
 (batchId=7)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[windowing_rank] 
(batchId=58)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[windowing_streaming] 
(batchId=74)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[windowing_udaf2] 
(batchId=16)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[windowing_udaf] 
(batchId=73)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[windowing_windowspec3] 
(batchId=42)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[windowing_windowspec4] 
(batchId=73)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[windowing_windowspec] 
(batchId=19)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[cbo_rp_windowing_2]
 (batchId=168)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[cbo_subq_in]
 (batchId=169)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[cbo_windowing]
 (batchId=176)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[cte_1] 
(batchId=186)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[explainuser_1]
 (batchId=171)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[groupby_resolution]
 (batchId=173)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[lineage2] 
(batchId=177)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[lineage3] 
(batchId=174)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_smb_ptf]
 (batchId=168)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[non_native_window_udf]
 (batchId=176)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[ptf] 
(batchId=165)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[ptf_streaming]
 (batchId=176)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sharedworkext]
 (batchId=170)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_in]
 (batchId=179)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_in_having]
 (batchId=178)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_notin]
 (batchId=181)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_scalar]
 (batchId=172)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_groupby_grouping_window]
 (batchId=184)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_outer_reference_windowed]
 (batchId=170)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_ptf_1]
 (batchId=183)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_ptf_part_simple]
 (batchId=170)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_windowing]
 (batchId=187)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_windowing_expressions]
 (batchId=184)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_windowing_gby2]
 (batchId=180)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_windowing_gby]
 (batchId=184)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_windowing_multipartitioning]
 (batchId=173)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_windowing_navfn]
 (batchId=163)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_windowing_order_null]
 (batchId=171)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_windowing_range_multiorder]
 (batchId=165)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_windowing_rank]
 (batchId=177)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_windowing_streaming]
 (batchId=176)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_windowing_windowspec4]
 (batchId=173)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_windowing_windowspec]
 (batchId=170)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorized_ptf]
 (batchId=179)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[windowing] 
(batchId=176)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[windowing_gby]
 (batchId=173)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[windowing_windowspec2]
 (batchId=178)
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_explainuser_1]
 (batchId=194)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[windowing_ll_no_neg]
 (batchId=101)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[cbo_subq_in] 
(batchId=127)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[groupby_resolution] 
(batchId=132)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ptf] (batchId=121)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ptf_decimal] 
(batchId=114)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ptf_general_queries]
 (batchId=116)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ptf_rcfile] 
(batchId=129)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ptf_seqfile] 
(batchId=147)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ptf_streaming] 
(batchId=138)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_in] 
(batchId=142)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_notin] 
(batchId=145)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_scalar] 
(batchId=131)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[union_remove_6_subq]
 (batchId=130)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorized_ptf] 
(batchId=142)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[windowing] 
(batchId=137)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query12] 
(batchId=299)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query20] 
(batchId=299)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query36] 
(batchId=299)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query44] 
(batchId=299)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query47] 
(batchId=299)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query49] 
(batchId=299)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query51] 
(batchId=299)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query53] 
(batchId=299)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query57] 
(batchId=299)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query63] 
(batchId=299)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query67] 
(batchId=299)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query70] 
(batchId=299)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query86] 
(batchId=299)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query89] 
(batchId=299)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query98] 
(batchId=299)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query12] 
(batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query20] 
(batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query36] 
(batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query47] 
(batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query49] 
(batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query51] 
(batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query53] 
(batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query57] 
(batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query63] 
(batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query89] 
(batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query98] 
(batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query12] 
(batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query20] 
(batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query36] 
(batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query44] 
(batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query47] 
(batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query49] 
(batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query51] 
(batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query53] 
(batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query57] 
(batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query63] 
(batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query67] 
(batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query70] 
(batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query86] 
(batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query89] 
(batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query98] 
(batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query12]
 (batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query20]
 (batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query36]
 (batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query47]
 (batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query49]
 (batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query51]
 (batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query53]
 (batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query57]
 (batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query63]
 (batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query89]
 (batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query98]
 (batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[mv_query44]
 (batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[mv_query67]
 (batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query12]
 (batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query20]
 (batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query36]
 (batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query44]
 (batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query47]
 (batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query49]
 (batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query51]
 (batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query53]
 (batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query57]
 (batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query63]
 (batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query67]
 (batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query70]
 (batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query86]
 (batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query89]
 (batchId=297)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[query98]
 (batchId=297)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/18629/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18629/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18629/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 180 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12980517 - PreCommit-HIVE-Build

> Simplify SemanticAnalyzer by removing unused code
> -------------------------------------------------
>
>                 Key: HIVE-22191
>                 URL: https://issues.apache.org/jira/browse/HIVE-22191
>             Project: Hive
>          Issue Type: Task
>          Components: Hive
>            Reporter: Akos Dombi
>            Assignee: Akos Dombi
>            Priority: Major
>         Attachments: HIVE-22191.2.patch, HIVE-22191.patch
>
>
> Simplify {{SemanticAnalyzer}} by:
>  - Remove dead code
>  - Simplify returning statements
>  - Use interfaces types for parameters/fields/variables where it is 
> straightforward to migrate
>  - Make visibility stricter where it is possible
>  - Check logging to use parametrised logging
>  - Removing unnecessary keywords (e.g.: {{static}})
>  - Some code part could be simplified by using Java 8 features
> I think this is crucial step as this class already contains 15000+ lines of 
> code which is screaming for splitting into more reasonable classes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to