[ https://issues.apache.org/jira/browse/HIVE-22191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16937682#comment-16937682 ]
Hive QA commented on HIVE-22191: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12981301/HIVE-22191.5.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17007 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.llap.cache.TestBuddyAllocator.testMTT[2] (batchId=363) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18720/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18720/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18720/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12981301 - PreCommit-HIVE-Build > Simplify SemanticAnalyzer by removing unused code > ------------------------------------------------- > > Key: HIVE-22191 > URL: https://issues.apache.org/jira/browse/HIVE-22191 > Project: Hive > Issue Type: Task > Components: Hive > Reporter: Akos Dombi > Assignee: Akos Dombi > Priority: Major > Attachments: HIVE-22191.2.patch, HIVE-22191.3.patch, > HIVE-22191.4.patch, HIVE-22191.5.patch, HIVE-22191.patch > > > Simplify {{SemanticAnalyzer}} by: > - Remove dead code > - Simplify returning statements > - Use interfaces types for parameters/fields/variables where it is > straightforward to migrate > - Make visibility stricter where it is possible > - Check logging to use parametrised logging > - Removing unnecessary keywords (e.g.: {{static}}) > - Some code part could be simplified by using Java 8 features > I think this is crucial step as this class already contains 15000+ lines of > code which is screaming for splitting into more reasonable classes. -- This message was sent by Atlassian Jira (v8.3.4#803005)