[
https://issues.apache.org/jira/browse/HIVE-22312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949806#comment-16949806
]
Hive QA commented on HIVE-22312:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
52s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
52s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
9s{color} | {color:blue} ql in master has 1549 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
50s{color} | {color:blue} itests/util in master has 53 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
20s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
28s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
37s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
15s{color} | {color:red} itests/util: The patch generated 70 new + 1 unchanged
- 1 fixed = 71 total (was 2) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
14s{color} | {color:green} ql in the patch passed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
53s{color} | {color:green} itests/util generated 0 new + 52 unchanged - 1 fixed
= 52 total (was 53) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
15s{color} | {color:red} The patch generated 3 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 30m 24s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-18955/dev-support/hive-personality.sh
|
| git revision | master / f16509a |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18955/yetus/diff-checkstyle-itests_util.txt
|
| asflicense |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18955/yetus/patch-asflicense-problems.txt
|
| modules | C: ql itests itests/util U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18955/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> MapJoinCounterHook doesnot work for tez
> ---------------------------------------
>
> Key: HIVE-22312
> URL: https://issues.apache.org/jira/browse/HIVE-22312
> Project: Hive
> Issue Type: Bug
> Components: Hive
> Affects Versions: All Versions
> Reporter: Pulkit Sharma
> Assignee: Pulkit Sharma
> Priority: Major
> Attachments: HIVE-22312.01.patch
>
>
> In [HIVE-1792|https://issues.apache.org/jira/browse/HIVE-1792],
> MapJoinCounterHook hook was added to track joins that get converted to map
> join. This hook gets List of Tasks from hookContext and check Tag associated
> with each task. For mr, we create Conditional tasks in case of joins and add
> tags for respective join conversions. This does not work in case of tez as we
> only create TezTask(no Conditional Task is created) which can handle multiple
> joins in contrast to one Conditional Task per join in mr.
> The current approach will fail even if we add tag to TezTask as it can have
> multiple joins of the same type which will require counter.
> One possible solution for tez, is to parse query-plan after query completion
> which we get from hookContext to get workGraph. Using workGraph, we can walk
> through Operator Tree to find join conversions.
> If this approach looks good, I can raise Pull Request
> cc [~ashutoshc] [~jcamachorodriguez] [~pxiong]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
