[ 
https://issues.apache.org/jira/browse/HIVE-22312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949811#comment-16949811
 ] 

Hive QA commented on HIVE-22312:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12982793/HIVE-22312.01.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17521 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.ql.metadata.TestHiveRemote.testGetAndDropTables 
(batchId=334)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/18955/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18955/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18955/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12982793 - PreCommit-HIVE-Build

> MapJoinCounterHook doesnot work for tez
> ---------------------------------------
>
>                 Key: HIVE-22312
>                 URL: https://issues.apache.org/jira/browse/HIVE-22312
>             Project: Hive
>          Issue Type: Bug
>          Components: Hive
>    Affects Versions: All Versions
>            Reporter: Pulkit Sharma
>            Assignee: Pulkit Sharma
>            Priority: Major
>         Attachments: HIVE-22312.01.patch
>
>
> In [HIVE-1792|https://issues.apache.org/jira/browse/HIVE-1792], 
> MapJoinCounterHook hook was added to track joins that get converted to map 
> join. This hook gets List of Tasks from hookContext and check Tag associated 
> with each task. For mr, we create Conditional tasks in case of joins and add 
> tags for respective join conversions. This does not work in case of tez as we 
> only create TezTask(no Conditional Task is created) which can handle multiple 
> joins in contrast to one Conditional Task per join in mr.
> The current approach will fail even if we add tag to TezTask as it can have 
> multiple joins of the same type which will require counter.
> One possible solution for tez, is to parse query-plan after query completion 
> which we get from hookContext to get workGraph. Using workGraph, we can walk 
> through Operator Tree to find join conversions.
>  If this approach looks good, I can raise Pull Request
> cc [~ashutoshc] [~jcamachorodriguez] [~pxiong] 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to