[
https://issues.apache.org/jira/browse/HIVE-21258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957521#comment-16957521
]
Hive QA commented on HIVE-21258:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12983749/HIVE-21258.2.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 17545 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19117/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19117/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19117/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12983749 - PreCommit-HIVE-Build
> Streamline and Add Warning to PrimitiveObjectInspectorFactory.java
> ------------------------------------------------------------------
>
> Key: HIVE-21258
> URL: https://issues.apache.org/jira/browse/HIVE-21258
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 4.0.0, 3.2.0
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Minor
> Attachments: HIVE-21258.1.patch, HIVE-21258.2.patch
>
>
> I just got bit by something pretty good, so I would like to propose adding a
> developer-facing warning into the logs to avoid this situation again.
> Also, this code contains a cache and the cache is pre-populated. Can remove
> a bunch of code, and maybe a little bit of memory, if the cache is populated
> on demand. Also, use new Map {{computeIfAbsent}} API.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
