[ 
https://issues.apache.org/jira/browse/HIVE-21258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957829#comment-16957829
 ] 

David Mollitor commented on HIVE-21258:
---------------------------------------

[~pvary] Please let me know if you have a few minutes to review.

> Streamline and Add Warning to PrimitiveObjectInspectorFactory.java
> ------------------------------------------------------------------
>
>                 Key: HIVE-21258
>                 URL: https://issues.apache.org/jira/browse/HIVE-21258
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 4.0.0, 3.2.0
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Minor
>         Attachments: HIVE-21258.1.patch, HIVE-21258.2.patch
>
>
> I just got bit by something pretty good, so I would like to propose adding a 
> developer-facing warning into the logs to avoid this situation again.
> Also, this code contains a cache and the cache is pre-populated.  Can remove 
> a bunch of code, and maybe a little bit of memory, if the cache is populated 
> on demand.  Also, use new Map {{computeIfAbsent}} API.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to