[
https://issues.apache.org/jira/browse/HIVE-11663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14716190#comment-14716190
]
Lefty Leverenz commented on HIVE-11663:
---------------------------------------
Review comments for the first patch:
# conf/hive-default.xml.template is now generated from HiveConf.java (see the
WARNING!!! lines in the patch) so it doesn't belong in the patch
# many or perhaps all files appear twice in the patch
# new configuration parameters in HiveConf.java need editing:
#* for *hive.server2.customized.udf.enabled* please change "Whether enable
hiveserver add customized udf from adding jars ..." to "Whether to enable
HiveServer2 or the Hive CLI to add a customized UDF from a jar file ..."
#* for *hive.server2.customized.udf.jars.path* please supply a parameter
description (even though it may seem obvious)
#* for *hive.server2.customized.udf.properties* change "The customized udf
functions' defination file. It's must be under $HIVE_HOME/conf directory. The
patern is as below." to "The customized UDF functions' definition file. It
must be under the $HIVE_HOME/conf directory. The pattern is as below."
#* for *hive.server2.customized.udf.defination.list* change "defination" to
"definition" and for HIVE_SERVER2_CUSTOMIZED_UDF_DEFINATION_LIST similarly
change "DEFINATION" to "DEFINITION" (also change all occurrences elsewhere in
the patch -- I count 26 but that includes the template file and duplicate files)
#* for the description of *hive.server2.customized.udf.defination.list*
presumably the hive.thrift.customized.* parameters are supposed to be
hive.server2.customized.* and other edits are needed:
{code}
+ "The customized UDF functions' definition list. For example, if
there is a UDF jar on the \n" +
+ "${hive.server2.customized.udf.jars.path} containing a foo.bar
class which defines a UDF \n" +
+ "function named test, then you can add \'foo.bar:test\' to the
property \n" +
+ "hive.server2.customized.udf.definition.list. Any additional
definitions are separated with commas.\n" +
+ "Note that this property depends on
hive.server2.customized.udf.enabled being set to true."
{code}
> Auto load/unload custom udf function for hive cli and hiveserver2
> -----------------------------------------------------------------
>
> Key: HIVE-11663
> URL: https://issues.apache.org/jira/browse/HIVE-11663
> Project: Hive
> Issue Type: Improvement
> Components: CLI, Configuration
> Affects Versions: 0.14.0, 1.0.0, 1.0.1, 1.1.1, 1.2.1
> Reporter: liuzongquan
> Assignee: liuzongquan
> Labels: features, patch
> Attachments: HIVE-11663.patch
>
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> when adding custom functions used in hiveserver2, the most method is re-build
> the hive source code, re-dist and restart hiveserver2. This way will produce
> big cost for service user and cluster manager. The best way, in my opinion,
> the custom udf should be like a plugin to the hiveserver2 and hive cli, and
> users should be add and remove at run-time, especially for hiveserver2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
