[ 
https://issues.apache.org/jira/browse/HIVE-11663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14731851#comment-14731851
 ] 

Lefty Leverenz commented on HIVE-11663:
---------------------------------------

[~liuzongquan@mls], sorry about the delay.  Here's my review of the 
configuration parameters in HiveConf.java, patch 2.

#  Why did you remove four comment lines starting with "// Hadoop Configuration 
Properties"?
#  Formatting:  For hive.server2.customized.udf.jars.path and 
hive.server2.customized.udf.properties please insert newlines (\n) in the 
descriptions as shown on lines 324 and 325, start the description of 
hive.server2.customized.udf.jars.path on a new line, and use standard indenting.
#  Capitalization:  For hive.server2.customized.udf.jars.path please change 
"The path on hdfs" to "The path on HDFS" and "means the hdfs path" to "means 
the HDFS path".
#  Edit:  For hive.server2.customized.udf.jars.path please change "When hdfs:// 
missing" to "When hdfs:// is missing".
#  Edits:  For hive.server2.customized.udf.properties please change "customized 
udf" to "customized UDF", change "defination" to "definition", change "It's 
must be under $" to "It must be under the $", and change "The patern is  as 
below." to "The pattern is".

A Review Board entry for this would make it easier to review, because comments 
could be posted on particular lines.


> Auto load/unload custom udf function for hive cli and hiveserver2
> -----------------------------------------------------------------
>
>                 Key: HIVE-11663
>                 URL: https://issues.apache.org/jira/browse/HIVE-11663
>             Project: Hive
>          Issue Type: Improvement
>          Components: CLI, Configuration
>    Affects Versions: 0.14.0, 1.0.0, 1.0.1, 1.1.1, 1.2.1
>            Reporter: liuzongquan
>            Assignee: liuzongquan
>              Labels: features, patch
>         Attachments: HIVE-11663-2.patch
>
>   Original Estimate: 96h
>          Time Spent: 96h
>  Remaining Estimate: 0h
>
> when adding custom functions used in hiveserver2, the most method is re-build 
> the hive source code, re-dist and restart hiveserver2. This way will produce 
> big cost for service user and cluster manager. The best way, in my opinion, 
> the custom udf should be like a plugin to the hiveserver2 and hive cli, and  
> users can add and remove at run-time, especially for hiveserver2.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to