[
https://issues.apache.org/jira/browse/HIVE-21198?focusedWorklogId=342164&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-342164
]
ASF GitHub Bot logged work on HIVE-21198:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Nov/19 21:21
Start Date: 12/Nov/19 21:21
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on pull request #550: HIVE-21198
Introduce a database object reference class
URL: https://github.com/apache/hive/pull/550#discussion_r345448803
##########
File path: storage-api/src/java/org/apache/hadoop/hive/common/TableName.java
##########
@@ -17,34 +17,45 @@
*/
package org.apache.hadoop.hive.common;
+import java.io.Serializable;
+import java.util.Objects;
+
/**
* A container for a fully qualified table name, i.e.
catalogname.databasename.tablename. Also
* includes utilities for string parsing.
*/
-public class TableName {
+public class TableName implements Serializable {
+
+ private static final long serialVersionUID = 1L;
+
+ /** Exception message thrown. */
+ private static final String ILL_ARG_EXCEPTION_MSG =
Review comment:
I don't really see the benefit of making this a static final string;
but anyway - I think the end goal is to stop the usage of any `tableName`
which contains `dbname` or any other stuff...and in that case the method in
which this is used should go away at some point - am I right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 342164)
> Introduce a database object reference class
> -------------------------------------------
>
> Key: HIVE-21198
> URL: https://issues.apache.org/jira/browse/HIVE-21198
> Project: Hive
> Issue Type: Sub-task
> Reporter: Zoltan Haindrich
> Assignee: David Lavati
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21198.1.patch, HIVE-21198.10.patch,
> HIVE-21198.11.patch, HIVE-21198.2.patch, HIVE-21198.3.patch,
> HIVE-21198.4.patch, HIVE-21198.5.patch, HIVE-21198.6.patch,
> HIVE-21198.7.patch, HIVE-21198.8.patch, HIVE-21198.9.patch
>
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> There are many places in which "{databasename}.{tablename}" is passed as a
> single string; there are some places where the they travel as 2 separate
> arguments.
> Idea would be to introduce a simple immutable class with 2 fields ; and pass
> these informations together. Making this better is required if we would be
> wanting to enable dot in tablenames
> HIVE-16907, HIVE-21151
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
