[
https://issues.apache.org/jira/browse/HIVE-21198?focusedWorklogId=342166&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-342166
]
ASF GitHub Bot logged work on HIVE-21198:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Nov/19 21:21
Start Date: 12/Nov/19 21:21
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on pull request #550: HIVE-21198
Introduce a database object reference class
URL: https://github.com/apache/hive/pull/550#discussion_r345399636
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
##########
@@ -897,10 +897,10 @@ private void analyzeAlterTableProps(String[] qualified,
HashMap<String, String>
}
// if table is being modified to be external we need to make sure
existing table
// doesn't have enabled constraint since constraints are disallowed with
such tables
- else if(entry.getKey().equals("external") &&
entry.getValue().equals("true")){
- if(hasConstraintsEnabled(qualified[1])){
+ else if (entry.getKey().equals("external") &&
entry.getValue().equals("true")) {
+ if (hasConstraintsEnabled(tableName.getTable())) {
Review comment:
this seems fishy to me...I guess if we hit this line when we are issuing an
alter on a table of different database; things might go south...or is there
something I'm missing?
(this is of course outside of the scope of this ticket)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 342166)
> Introduce a database object reference class
> -------------------------------------------
>
> Key: HIVE-21198
> URL: https://issues.apache.org/jira/browse/HIVE-21198
> Project: Hive
> Issue Type: Sub-task
> Reporter: Zoltan Haindrich
> Assignee: David Lavati
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21198.1.patch, HIVE-21198.10.patch,
> HIVE-21198.11.patch, HIVE-21198.2.patch, HIVE-21198.3.patch,
> HIVE-21198.4.patch, HIVE-21198.5.patch, HIVE-21198.6.patch,
> HIVE-21198.7.patch, HIVE-21198.8.patch, HIVE-21198.9.patch
>
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> There are many places in which "{databasename}.{tablename}" is passed as a
> single string; there are some places where the they travel as 2 separate
> arguments.
> Idea would be to introduce a simple immutable class with 2 fields ; and pass
> these informations together. Making this better is required if we would be
> wanting to enable dot in tablenames
> HIVE-16907, HIVE-21151
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
