[ https://issues.apache.org/jira/browse/HIVE-22736?focusedWorklogId=376258&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-376258 ]
ASF GitHub Bot logged work on HIVE-22736: ----------------------------------------- Author: ASF GitHub Bot Created on: 23/Jan/20 14:32 Start Date: 23/Jan/20 14:32 Worklog Time Spent: 10m Work Description: aasha commented on pull request #883: HIVE-22736 Support multiple encryption zones in replication URL: https://github.com/apache/hive/pull/883#discussion_r370151392 ########## File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java ########## @@ -138,15 +149,18 @@ private ReplChangeManager(Configuration conf) throws MetaException { if (!inited) { if (MetastoreConf.getBoolVar(conf, ConfVars.REPLCMENABLED)) { ReplChangeManager.enabled = true; - ReplChangeManager.cmroot = new Path(MetastoreConf.getVar(conf, ConfVars.REPLCMDIR)); ReplChangeManager.conf = conf; + //Create default cm root + Path cmroot = new Path(MetastoreConf.getVar(conf, ConfVars.REPLCMDIR)); FileSystem cmFs = cmroot.getFileSystem(conf); // Create cmroot with permission 700 if not exist if (!cmFs.exists(cmroot)) { cmFs.mkdirs(cmroot); cmFs.setPermission(cmroot, new FsPermission("700")); } + cmRootMapping.put(NO_ENCRYPTION, cmroot); Review comment: This is for REPLCMDIR. This will always be unencrypted. Encryption cm directory we have separated. If there is any unencrypted path for which recycle is called, we will use this. Else we will create a cm for that zone ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 376258) Time Spent: 1h 10m (was: 1h) > Support replication across multiple encryption zones > ---------------------------------------------------- > > Key: HIVE-22736 > URL: https://issues.apache.org/jira/browse/HIVE-22736 > Project: Hive > Issue Type: Task > Reporter: Aasha Medhi > Assignee: Aasha Medhi > Priority: Major > Labels: pull-request-available > Attachments: HIVE-22736.patch, HIVE-22736.patch, HIVE-22736.patch, > HIVE-22736.patch, HIVE-22736.patch, HIVE-22736.patch > > Time Spent: 1h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)