[
https://issues.apache.org/jira/browse/HIVE-22736?focusedWorklogId=376259&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-376259
]
ASF GitHub Bot logged work on HIVE-22736:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jan/20 14:34
Start Date: 23/Jan/20 14:34
Worklog Time Spent: 10m
Work Description: aasha commented on pull request #883: HIVE-22736
Support multiple encryption zones in replication
URL: https://github.com/apache/hive/pull/883#discussion_r370152190
##########
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java
##########
@@ -213,9 +227,18 @@ public int recycle(Path path, RecycleType type, boolean
ifPurge) throws IOExcept
switch (type) {
case MOVE: {
LOG.info("Moving {} to {}", path.toString(), cmPath.toString());
-
// Rename fails if the file with same name already exist.
- success = fs.rename(path, cmPath);
+ Retry<Boolean> retriable = new Retry<Boolean>(IOException.class) {
+ @Override
+ public Boolean execute() throws IOException {
+ return fs.rename(path, cmPath);
+ }
+ };
+ try {
+ success = retriable.run();
+ } catch (Exception e) {
+ throw new
MetaException(org.apache.hadoop.util.StringUtils.stringifyException(e));
Review comment:
Yes in this case it is just an IOException. But wanted to keep the Retry
interface generic. So added Exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 376259)
Time Spent: 1h 20m (was: 1h 10m)
> Support replication across multiple encryption zones
> ----------------------------------------------------
>
> Key: HIVE-22736
> URL: https://issues.apache.org/jira/browse/HIVE-22736
> Project: Hive
> Issue Type: Task
> Reporter: Aasha Medhi
> Assignee: Aasha Medhi
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22736.patch, HIVE-22736.patch, HIVE-22736.patch,
> HIVE-22736.patch, HIVE-22736.patch, HIVE-22736.patch
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
