[
https://issues.apache.org/jira/browse/HIVE-22881?focusedWorklogId=389761&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389761
]
ASF GitHub Bot logged work on HIVE-22881:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Feb/20 02:43
Start Date: 20/Feb/20 02:43
Worklog Time Spent: 10m
Work Description: jcamachor commented on pull request #919: HIVE-22881
rexutil usage
URL: https://github.com/apache/hive/pull/919#discussion_r381679711
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsWithStatsRule.java
##########
@@ -272,7 +274,11 @@ public RexNode visitCall(RexCall call) {
// If we did not reduce, check the children nodes
RexNode node = super.visitCall(call);
if (node != call) {
- node = RexUtil.simplify(rexBuilder, node);
+ // FIXME if this rule will make some changes; then it will invoke
simplify on all subtrees during exiting the recursion
Review comment:
Is this to fix in this patch or in a follow-up? Can you create a JIRA if
that is the case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 389761)
Time Spent: 20m (was: 10m)
> Revise non-recommended Calcite api calls
> ----------------------------------------
>
> Key: HIVE-22881
> URL: https://issues.apache.org/jira/browse/HIVE-22881
> Project: Hive
> Issue Type: Improvement
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22881.01.patch, HIVE-22881.02.patch,
> HIVE-22881.03.patch, HIVE-22881.03.patch, HIVE-22881.03.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> RexUtil.simplify* methods
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
