[
https://issues.apache.org/jira/browse/HIVE-22881?focusedWorklogId=389814&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389814
]
ASF GitHub Bot logged work on HIVE-22881:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Feb/20 06:42
Start Date: 20/Feb/20 06:42
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on pull request #919: HIVE-22881
rexutil usage
URL: https://github.com/apache/hive/pull/919#discussion_r381806268
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsWithStatsRule.java
##########
@@ -272,7 +274,11 @@ public RexNode visitCall(RexCall call) {
// If we did not reduce, check the children nodes
RexNode node = super.visitCall(call);
if (node != call) {
- node = RexUtil.simplify(rexBuilder, node);
+ // FIXME if this rule will make some changes; then it will invoke
simplify on all subtrees during exiting the recursion
Review comment:
It was there before; and I can't really do anything right now with
it...leaving a comment might be usefull if it lights up on someones profiler
To fix this we would need some way to keep track which nodes were simplified
already...that should be fixed in Calcite;and it might not even possible
(because the set of predicates might be different )
We might consider moving the simplification outside of the recursive phase -
that will certainly reduce the re-visit pressure; but could result in reduced
simplification in some cases (however considering how many places we are doing
this, that's unlikely) - it could be explored in a separate patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 389814)
Time Spent: 0.5h (was: 20m)
> Revise non-recommended Calcite api calls
> ----------------------------------------
>
> Key: HIVE-22881
> URL: https://issues.apache.org/jira/browse/HIVE-22881
> Project: Hive
> Issue Type: Improvement
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22881.01.patch, HIVE-22881.02.patch,
> HIVE-22881.03.patch, HIVE-22881.03.patch, HIVE-22881.03.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> RexUtil.simplify* methods
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
