[
https://issues.apache.org/jira/browse/HIVE-22962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17050895#comment-17050895
]
Hive QA commented on HIVE-22962:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12995509/HIVE-22962.02.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 59 failed/errored test(s), 18096 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ambiguitycheck]
(batchId=85)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cast1] (batchId=87)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[decimal_2] (batchId=72)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_aes_decrypt]
(batchId=62)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_aes_encrypt]
(batchId=100)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_crc32] (batchId=2)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_decode] (batchId=99)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_md5] (batchId=10)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_sha1] (batchId=8)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_sha2] (batchId=13)
org.apache.hadoop.hive.cli.TestKuduCliDriver.testCliDriver[kudu_queries]
(batchId=297)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_decimal_2]
(batchId=175)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testAlterPartition
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testAlterTable
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testAlterTableCascade
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testAlterViewParititon
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testColumnStatistics
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testComplexTable
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testComplexTypeApi
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testConcurrentMetastores
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testCreateAndGetTableWithDriver
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testCreateTableSettingId
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testDBLocationChange
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testDBOwner
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testDBOwnerChange
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testDatabase
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testDatabaseLocation
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testDatabaseLocationWithPermissionProblems
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testDropDatabaseCascadeMVMultiDB
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testDropTable
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testFilterLastPartition
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testFilterSinglePartition
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testFunctionWithResources
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testGetConfigValue
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testGetMetastoreUuid
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testGetPartitionsWithSpec
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testGetSchemaWithNoClassDefFoundError
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testGetTableObjects
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testGetUUIDInParallel
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testJDOPersistanceManagerCleanup
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testListPartitionNames
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testListPartitions
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testListPartitionsWihtLimitEnabled
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testNameMethods
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testPartition
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testPartitionFilter
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testPartitionFilterLike
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testRenamePartition
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testRetriableClientWithConnLifetime
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testSimpleFunction
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testSimpleTable
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testSimpleTypeApi
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testStatsFastTrivial
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testSynchronized
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testTableDatabase
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testTableFilter
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testUpdatePartitionStat_doesNotUpdateStats
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testValidateTableCols
(batchId=307)
org.apache.hive.minikdc.TestRemoteHiveMetaStoreKerberos.testVersion
(batchId=307)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/20940/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20940/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20940/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 59 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12995509 - PreCommit-HIVE-Build
> Reuse HiveRelFieldTrimmer instance across queries
> -------------------------------------------------
>
> Key: HIVE-22962
> URL: https://issues.apache.org/jira/browse/HIVE-22962
> Project: Hive
> Issue Type: Improvement
> Components: CBO
> Reporter: Jesus Camacho Rodriguez
> Assignee: Jesus Camacho Rodriguez
> Priority: Major
> Attachments: HIVE-22962.01.patch, HIVE-22962.02.patch,
> HIVE-22962.patch
>
>
> Currently we create multiple {{HiveRelFieldTrimmer}} instances per query.
> {{HiveRelFieldTrimmer}} uses a method dispatcher that has a built-in caching
> mechanism: given a certain object, it stores the method that was called for
> the object class. However, by instantiating the trimmer multiple times per
> query and across queries, we create a new dispatcher with each instantiation,
> thus effectively removing the caching mechanism that is built within the
> dispatcher.
> This issue is to reutilize the same {{HiveRelFieldTrimmer}} instance within a
> single query and across queries.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
