[ 
https://issues.apache.org/jira/browse/HIVE-22962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17051042#comment-17051042
 ] 

Hive QA commented on HIVE-22962:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12995565/HIVE-22962.03.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 35 failed/errored test(s), 18096 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestKuduCliDriver.testCliDriver[kudu_queries] 
(batchId=297)
org.apache.hadoop.hive.cli.TestMiniDruidCliDriver.testCliDriver[druid_materialized_view_rewrite_ssb]
 (batchId=205)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query78] 
(batchId=308)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query11] 
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query14] 
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query17] 
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query25] 
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query29] 
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query31] 
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query47] 
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query4] 
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query50] 
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query57] 
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query58] 
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query64] 
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query74] 
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query75] 
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query78] 
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query85] 
(batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query11]
 (batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query14]
 (batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query17]
 (batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query25]
 (batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query29]
 (batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query31]
 (batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query47]
 (batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query4]
 (batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query50]
 (batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query57]
 (batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query58]
 (batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query64]
 (batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query72]
 (batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query74]
 (batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query75]
 (batchId=306)
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query85]
 (batchId=306)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/20943/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20943/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20943/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 35 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12995565 - PreCommit-HIVE-Build

> Reuse HiveRelFieldTrimmer instance across queries
> -------------------------------------------------
>
>                 Key: HIVE-22962
>                 URL: https://issues.apache.org/jira/browse/HIVE-22962
>             Project: Hive
>          Issue Type: Improvement
>          Components: CBO
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Jesus Camacho Rodriguez
>            Priority: Major
>         Attachments: HIVE-22962.01.patch, HIVE-22962.02.patch, 
> HIVE-22962.03.patch, HIVE-22962.patch
>
>
> Currently we create multiple {{HiveRelFieldTrimmer}} instances per query. 
> {{HiveRelFieldTrimmer}} uses a method dispatcher that has a built-in caching 
> mechanism: given a certain object, it stores the method that was called for 
> the object class. However, by instantiating the trimmer multiple times per 
> query and across queries, we create a new dispatcher with each instantiation, 
> thus effectively removing the caching mechanism that is built within the 
> dispatcher.
> This issue is to reutilize the same {{HiveRelFieldTrimmer}} instance within a 
> single query and across queries.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to