[
https://issues.apache.org/jira/browse/HIVE-21218?focusedWorklogId=398135&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-398135
]
ASF GitHub Bot logged work on HIVE-21218:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Mar/20 05:03
Start Date: 05/Mar/20 05:03
Worklog Time Spent: 10m
Work Description: davidov541 commented on pull request #933: HIVE-21218:
Adding support for Confluent Kafka Avro message format
URL: https://github.com/apache/hive/pull/933#discussion_r388079696
##########
File path:
kafka-handler/src/test/org/apache/hadoop/hive/kafka/AvroBytesConverterTest.java
##########
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.kafka;
+
+import com.google.common.collect.Maps;
+import io.confluent.kafka.schemaregistry.client.MockSchemaRegistryClient;
+import io.confluent.kafka.serializers.AbstractKafkaAvroSerDeConfig;
+import io.confluent.kafka.serializers.KafkaAvroSerializer;
+import org.apache.avro.Schema;
+import org.apache.hadoop.hive.serde2.avro.AvroGenericRecordWritable;
+import org.junit.Assert;
+import org.junit.BeforeClass;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.ExpectedException;
+
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.Map;
+
+/**
+ * Test class for Hive Kafka Avro SerDe with variable bytes skipped.
+ */
+public class AvroBytesConverterTest {
+ private static SimpleRecord simpleRecord =
SimpleRecord.newBuilder().setId("123").setName("test").build();
+ private static byte[] simpleRecordConfluentBytes;
+
+ @Rule
+ public ExpectedException exception = ExpectedException.none();
+
+ /**
+ * Use the KafkaAvroSerializer from Confluent to serialize the simpleRecord.
+ */
+ @BeforeClass
+ public static void setUp() {
+ Map<String, String> config = Maps.newHashMap();
+ config.put(AbstractKafkaAvroSerDeConfig.SCHEMA_REGISTRY_URL_CONFIG,
"http://localhost:8081";);
+ KafkaAvroSerializer avroSerializer = new KafkaAvroSerializer(new
MockSchemaRegistryClient());
+ avroSerializer.configure(config, false);
+ simpleRecordConfluentBytes = avroSerializer.serialize("temp",
simpleRecord);
+ }
+
+ private void runConversionTest(KafkaSerDe.AvroBytesConverter conv, byte[]
serializedSimpleRecord) {
Review comment:
We are instantiating KafkaSerDe.AvroBytesConverter for the normal case and
KafkaSerDe.AvroSkipBytesConverter for the other cases. If we wanted to move
creation of the converter into the function, it would require an if-else
statement, making it more complex than just doing this. Additionally, this
gives us the leeway to better add tests if more converters are needed later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 398135)
Time Spent: 12h 10m (was: 12h)
> KafkaSerDe doesn't support topics created via Confluent Avro serializer
> -----------------------------------------------------------------------
>
> Key: HIVE-21218
> URL: https://issues.apache.org/jira/browse/HIVE-21218
> Project: Hive
> Issue Type: Bug
> Components: kafka integration, Serializers/Deserializers
> Affects Versions: 3.1.1
> Reporter: Milan Baran
> Assignee: David McGinnis
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21218.2.patch, HIVE-21218.3.patch,
> HIVE-21218.4.patch, HIVE-21218.5.patch, HIVE-21218.patch
>
> Time Spent: 12h 10m
> Remaining Estimate: 0h
>
> According to [Google
> groups|https://groups.google.com/forum/#!topic/confluent-platform/JYhlXN0u9_A]
> the Confluent avro serialzier uses propertiary format for kafka value -
> <magic_byte 0x00><4 bytes of schema ID><regular avro bytes for object that
> conforms to schema>.
> This format does not cause any problem for Confluent kafka deserializer which
> respect the format however for hive kafka handler its bit a problem to
> correctly deserialize kafka value, because Hive uses custom deserializer from
> bytes to objects and ignores kafka consumer ser/deser classes provided via
> table property.
> It would be nice to support Confluent format with magic byte.
> Also it would be great to support Schema registry as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
