[ 
https://issues.apache.org/jira/browse/HIVE-21218?focusedWorklogId=398141&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-398141
 ]

ASF GitHub Bot logged work on HIVE-21218:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Mar/20 05:16
            Start Date: 05/Mar/20 05:16
    Worklog Time Spent: 10m 
      Work Description: davidov541 commented on pull request #933: HIVE-21218: 
Adding support for Confluent Kafka Avro message format
URL: https://github.com/apache/hive/pull/933#discussion_r388082372
 
 

 ##########
 File path: kafka-handler/README.md
 ##########
 @@ -50,6 +50,9 @@ ALTER TABLE
 SET TBLPROPERTIES (
   "kafka.serde.class" = "org.apache.hadoop.hive.serde2.avro.AvroSerDe");
 ```
+
+If you use Confluent Avro serialzier/deserializer with Schema Registry you may 
want to remove 5 bytes from beginning that represents magic byte + schema ID 
from registry.
 
 Review comment:
   I'm not sure how that is germane to this thread or to this changelist at 
all. Skipping the bytes does not currently have any connection to having a 
schema, which is already implemented as part of the Kafka Avro support. The 
system would work the same as it would if you didn't specify a schema in the 
first place. I don't see any tests in the other parts which test this, although 
there are plenty of query tests which test the use of the literal and URL 
properties, so I suspect there is one such test there. Given that that is 
orthagonal to this problem, however, I see no need to add another test to this 
changeset for that.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 398141)
    Time Spent: 12.5h  (was: 12h 20m)

> KafkaSerDe doesn't support topics created via Confluent Avro serializer
> -----------------------------------------------------------------------
>
>                 Key: HIVE-21218
>                 URL: https://issues.apache.org/jira/browse/HIVE-21218
>             Project: Hive
>          Issue Type: Bug
>          Components: kafka integration, Serializers/Deserializers
>    Affects Versions: 3.1.1
>            Reporter: Milan Baran
>            Assignee: David McGinnis
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-21218.2.patch, HIVE-21218.3.patch, 
> HIVE-21218.4.patch, HIVE-21218.5.patch, HIVE-21218.patch
>
>          Time Spent: 12.5h
>  Remaining Estimate: 0h
>
> According to [Google 
> groups|https://groups.google.com/forum/#!topic/confluent-platform/JYhlXN0u9_A]
>  the Confluent avro serialzier uses propertiary format for kafka value - 
> <magic_byte 0x00><4 bytes of schema ID><regular avro bytes for object that 
> conforms to schema>. 
> This format does not cause any problem for Confluent kafka deserializer which 
> respect the format however for hive kafka handler its bit a problem to 
> correctly deserialize kafka value, because Hive uses custom deserializer from 
> bytes to objects and ignores kafka consumer ser/deser classes provided via 
> table property.
> It would be nice to support Confluent format with magic byte.
> Also it would be great to support Schema registry as well.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to