[
https://issues.apache.org/jira/browse/HIVE-22821?focusedWorklogId=400200&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-400200
]
ASF GitHub Bot logged work on HIVE-22821:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Mar/20 15:58
Start Date: 09/Mar/20 15:58
Worklog Time Spent: 10m
Work Description: szlta commented on pull request #909: HIVE-22821
URL: https://github.com/apache/hive/pull/909#discussion_r389787317
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java
##########
@@ -221,6 +227,9 @@ public void debugDumpShort(StringBuilder sb) {
metadataCache, dataCache, bufferManagerOrc, conf, cacheMetrics,
ioMetrics, tracePool);
this.genericCvp = isEncodeEnabled ? new GenericColumnVectorProducer(
serdeCache, bufferManagerGeneric, conf, cacheMetrics, ioMetrics,
tracePool) : null;
+ proactiveEvictionExecutor = Executors.newSingleThreadExecutor(
Review comment:
Like I said, I'm fine with relying on RPC threadpool only on the LLAP daemon
side. I'm not talking about that anymore (you can see I amended that change
already)
What I'm talking about now is HS2 side:
- purge currently will block user side:
https://github.com/szlta/hive/blob/HIVE-22821/ql/src/java/org/apache/hadoop/hive/ql/processors/LlapCacheResourceProcessor.java#L141
- while proactive eviction - I'd propose - should not:
https://github.com/szlta/hive/blob/HIVE-22821/ql/src/java/org/apache/hadoop/hive/llap/ProactiveEviction.java#L79
That's the difference I'm interested in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 400200)
Time Spent: 2.5h (was: 2h 20m)
> Add necessary endpoints for proactive cache eviction
> ----------------------------------------------------
>
> Key: HIVE-22821
> URL: https://issues.apache.org/jira/browse/HIVE-22821
> Project: Hive
> Issue Type: Sub-task
> Components: llap
> Reporter: Ádám Szita
> Assignee: Ádám Szita
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22821.0.patch, HIVE-22821.1.patch,
> HIVE-22821.2.patch
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Implement the parts required for iHS2 -> LLAP daemons communication:
> * protobuf message schema and endpoints
> * Hive configuration
> * for use cases:
> ** dropping db
> ** dropping table
> ** dropping partition from a table
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
