[
https://issues.apache.org/jira/browse/HIVE-22821?focusedWorklogId=400369&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-400369
]
ASF GitHub Bot logged work on HIVE-22821:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Mar/20 20:59
Start Date: 09/Mar/20 20:59
Worklog Time Spent: 10m
Work Description: szlta commented on pull request #909: HIVE-22821
URL: https://github.com/apache/hive/pull/909#discussion_r389958291
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java
##########
@@ -221,6 +227,9 @@ public void debugDumpShort(StringBuilder sb) {
metadataCache, dataCache, bufferManagerOrc, conf, cacheMetrics,
ioMetrics, tracePool);
this.genericCvp = isEncodeEnabled ? new GenericColumnVectorProducer(
serdeCache, bufferManagerGeneric, conf, cacheMetrics, ioMetrics,
tracePool) : null;
+ proactiveEvictionExecutor = Executors.newSingleThreadExecutor(
Review comment:
Okay, so suppose you use beeline and do a drop table statement:
A thread from HiveServer2-Handler-Pool will pick up the incoming Thrift
request and execute.
Execution will go into DropTableOperation. Anything happening here will
prevent this thread from finishing and thus you as the user on the beeline side
(as thrift connects you) will have to wait.
If we invoke a proactive eviction from DropTableOperation (which this change
does) obviously the user on beeline side will see this addition processing time
for their query.
Now if this additional time is long - that could be bad, since they only
wanted to drop a table and now they're waiting extra seconds if the
DropTableOperation 'waits' for many LLAP daemons to finish their eviction on
their big cache structure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 400369)
Time Spent: 2h 50m (was: 2h 40m)
> Add necessary endpoints for proactive cache eviction
> ----------------------------------------------------
>
> Key: HIVE-22821
> URL: https://issues.apache.org/jira/browse/HIVE-22821
> Project: Hive
> Issue Type: Sub-task
> Components: llap
> Reporter: Ádám Szita
> Assignee: Ádám Szita
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22821.0.patch, HIVE-22821.1.patch,
> HIVE-22821.2.patch
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Implement the parts required for iHS2 -> LLAP daemons communication:
> * protobuf message schema and endpoints
> * Hive configuration
> * for use cases:
> ** dropping db
> ** dropping table
> ** dropping partition from a table
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
