[ 
https://issues.apache.org/jira/browse/HIVE-22998?focusedWorklogId=401926&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-401926
 ]

ASF GitHub Bot logged work on HIVE-22998:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Mar/20 03:25
            Start Date: 12/Mar/20 03:25
    Worklog Time Spent: 10m 
      Work Description: maheshk114 commented on pull request #945: HIVE-22998 
Dump partition info if hive.repl.dump.metadata.only.for.ex…
URL: https://github.com/apache/hive/pull/945#discussion_r391378029
 
 

 ##########
 File path: 
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/events/AbstractEventHandler.java
 ##########
 @@ -94,7 +94,8 @@ protected void writeFileEntry(String dbName, Table table, 
String file, BufferedW
           throws IOException, LoginException, MetaException, 
HiveFatalException {
     HiveConf hiveConf = withinContext.hiveConf;
     String distCpDoAsUser = 
hiveConf.getVar(HiveConf.ConfVars.HIVE_DISTCP_DOAS_USER);
-    if (!Utils.shouldDumpMetaDataOnly(table, withinContext.hiveConf)) {
+    if (!Utils.shouldDumpMetaDataOnlyForExternalTables(table, 
withinContext.hiveConf)
 
 Review comment:
   for external table we don't dump data related events ..so i don't think we 
need to add this check 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 401926)

> Dump partition info if hive.repl.dump.metadata.only.for.external.table conf 
> is enabled 
> ---------------------------------------------------------------------------------------
>
>                 Key: HIVE-22998
>                 URL: https://issues.apache.org/jira/browse/HIVE-22998
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Aasha Medhi
>            Assignee: Aasha Medhi
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-22998.01.patch, HIVE-22998.02.patch, 
> HIVE-22998.03.patch, HIVE-22998.04.patch, HIVE-22998.05.patch, 
> HIVE-22998.06.patch, HIVE-22998.07.patch, HIVE-22998.08.patch, 
> HIVE-22998.09.patch, HIVE-22998.patch
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to