[
https://issues.apache.org/jira/browse/HIVE-22998?focusedWorklogId=402006&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-402006
]
ASF GitHub Bot logged work on HIVE-22998:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Mar/20 07:27
Start Date: 12/Mar/20 07:27
Worklog Time Spent: 10m
Work Description: maheshk114 commented on pull request #945: HIVE-22998
Dump partition info if hive.repl.dump.metadata.only.for.ex…
URL: https://github.com/apache/hive/pull/945#discussion_r391439953
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java
##########
@@ -75,11 +75,20 @@ public TableExport(Paths paths, TableSpec tableSpec,
ReplicationSpec replication
? null
: tableSpec;
this.replicationSpec = replicationSpec;
- if (this.tableSpec != null && this.tableSpec.tableHandle!=null &&
(this.tableSpec.tableHandle.isView() ||
- Utils.shouldDumpMetaDataOnly(this.tableSpec.tableHandle, conf))) {
- this.replicationSpec.setIsMetadataOnly(true);
-
- this.tableSpec.tableHandle.setStatsStateLikeNewTable();
+ if (this.tableSpec != null && this.tableSpec.tableHandle!=null) {
+ //If table is view or if should dump metadata only flag used by DAS is
set to true
+ //enable isMetadataOnly
+ if (this.tableSpec.tableHandle.isView() ||
Utils.shouldDumpMetaDataOnly(conf)) {
+ this.tableSpec.tableHandle.setStatsStateLikeNewTable();
+ this.replicationSpec.setIsMetadataOnly(true);
+ }
+ //If table is view or if should dump metadata only for external table
flag is set to true
+ //enable isMetadataOnlyForExternalTable
+ if (this.tableSpec.tableHandle.isView()
+ ||
Utils.shouldDumpMetaDataOnlyForExternalTables(this.tableSpec.tableHandle,
conf)) {
+ this.tableSpec.tableHandle.setStatsStateLikeNewTable();
+ this.replicationSpec.setMetadataOnlyForExternalTables(true);
Review comment:
No where this flag is accessed ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 402006)
Time Spent: 1h 50m (was: 1h 40m)
> Dump partition info if hive.repl.dump.metadata.only.for.external.table conf
> is enabled
> ---------------------------------------------------------------------------------------
>
> Key: HIVE-22998
> URL: https://issues.apache.org/jira/browse/HIVE-22998
> Project: Hive
> Issue Type: Bug
> Reporter: Aasha Medhi
> Assignee: Aasha Medhi
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22998.01.patch, HIVE-22998.02.patch,
> HIVE-22998.03.patch, HIVE-22998.04.patch, HIVE-22998.05.patch,
> HIVE-22998.06.patch, HIVE-22998.07.patch, HIVE-22998.08.patch,
> HIVE-22998.09.patch, HIVE-22998.10.patch, HIVE-22998.11.patch,
> HIVE-22998.patch
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
