[ https://issues.apache.org/jira/browse/HIVE-22875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17065123#comment-17065123 ]
Hive QA commented on HIVE-22875: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12997466/HIVE-22875.04.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 18125 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testMinorCompactionWhileStreaming (batchId=270) org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testMinorCompactionWhileStreamingAfterAbort (batchId=270) org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testMinorCompactionWhileStreamingWithAbort (batchId=270) org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testMinorCompactionWhileStreamingWithAbortInMiddle (batchId=270) org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testMinorCompactionWhileStreamingWithSplitUpdate (batchId=270) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21238/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21238/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21238/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 5 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12997466 - PreCommit-HIVE-Build > Refactor query creation in QueryCompactor implementations > --------------------------------------------------------- > > Key: HIVE-22875 > URL: https://issues.apache.org/jira/browse/HIVE-22875 > Project: Hive > Issue Type: Improvement > Reporter: Karen Coppage > Assignee: Karen Coppage > Priority: Major > Attachments: HIVE-22875.01.patch, HIVE-22875.02.patch, > HIVE-22875.02.patch, HIVE-22875.03.patch, HIVE-22875.04.patch > > > There is a lot of repetition where creation/compaction/drop queries are > created in MajorQueryCompactor, MinorQueryCompactor, MmMajorQueryCompactor > and MmMinorQueryCompactor. > Initial idea is to create a CompactionQueryBuilder that all 4 implementations > would use. -- This message was sent by Atlassian Jira (v8.3.4#803005)