[ https://issues.apache.org/jira/browse/HIVE-22875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17066139#comment-17066139 ]
Hive QA commented on HIVE-22875: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12997553/HIVE-22875.05.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 18125 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21253/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21253/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21253/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12997553 - PreCommit-HIVE-Build > Refactor query creation in QueryCompactor implementations > --------------------------------------------------------- > > Key: HIVE-22875 > URL: https://issues.apache.org/jira/browse/HIVE-22875 > Project: Hive > Issue Type: Improvement > Reporter: Karen Coppage > Assignee: Karen Coppage > Priority: Major > Attachments: HIVE-22875.01.patch, HIVE-22875.02.patch, > HIVE-22875.02.patch, HIVE-22875.03.patch, HIVE-22875.04.patch, > HIVE-22875.05.patch > > > There is a lot of repetition where creation/compaction/drop queries are > created in MajorQueryCompactor, MinorQueryCompactor, MmMajorQueryCompactor > and MmMinorQueryCompactor. > Initial idea is to create a CompactionQueryBuilder that all 4 implementations > would use. -- This message was sent by Atlassian Jira (v8.3.4#803005)