[
https://issues.apache.org/jira/browse/HIVE-23051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17066988#comment-17066988
]
Hive QA commented on HIVE-23051:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12997682/HIVE-23051.3.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 81 failed/errored test(s), 18133 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[delete_all_non_partitioned]
(batchId=174)
org.apache.hadoop.hive.ql.io.orc.TestOrcRawRecordMerger.testNewBaseAndDelta
(batchId=333)
org.apache.hadoop.hive.ql.io.orc.TestOrcRawRecordMerger.testRecordReaderIncompleteDelta
(batchId=333)
org.apache.hadoop.hive.ql.parse.TestReplicationOfHiveStreaming.testHiveStreamingDynamicPartitionWithTxnBatchSizeAsOne
(batchId=256)
org.apache.hadoop.hive.ql.parse.TestReplicationOfHiveStreaming.testHiveStreamingStaticPartitionWithTxnBatchSizeAsOne
(batchId=256)
org.apache.hadoop.hive.ql.parse.TestReplicationOfHiveStreaming.testHiveStreamingUnpartitionedWithTxnBatchSizeAsOne
(batchId=256)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.majorCompactAfterAbort
(batchId=255)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.majorCompactAfterAbortNew
(batchId=255)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.majorCompactWhileStreaming
(batchId=255)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.majorCompactWhileStreamingForSplitUpdate
(batchId=255)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.majorCompactWhileStreamingForSplitUpdateNew
(batchId=255)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.minorCompactAfterAbort
(batchId=255)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.minorCompactAfterAbortNew
(batchId=255)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.minorCompactWhileStreaming
(batchId=255)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.minorCompactWhileStreamingWithSplitUpdate
(batchId=255)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.minorCompactWhileStreamingWithSplitUpdateNew
(batchId=255)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.testStatsAfterCompactionPartTbl
(batchId=255)
org.apache.hadoop.hive.ql.txn.compactor.TestCompactor.testStatsAfterCompactionPartTblNew
(batchId=255)
org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testMinorCompactionWhileStreaming
(batchId=270)
org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testMinorCompactionWhileStreamingAfterAbort
(batchId=270)
org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testMinorCompactionWhileStreamingWithAbort
(batchId=270)
org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testMinorCompactionWhileStreamingWithAbortInMiddle
(batchId=270)
org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testMinorCompactionWhileStreamingWithSplitUpdate
(batchId=270)
org.apache.hive.hcatalog.streaming.TestStreaming.testBucketing (batchId=226)
org.apache.hive.hcatalog.streaming.TestStreaming.testBucketingWhereBucketColIsNotFirstCol
(batchId=226)
org.apache.hive.hcatalog.streaming.TestStreaming.testConcurrentTransactionBatchCommits
(batchId=226)
org.apache.hive.hcatalog.streaming.TestStreaming.testErrorHandling (batchId=226)
org.apache.hive.hcatalog.streaming.TestStreaming.testFileDump (batchId=226)
org.apache.hive.hcatalog.streaming.TestStreaming.testFileDumpCorruptDataFiles
(batchId=226)
org.apache.hive.hcatalog.streaming.TestStreaming.testFileDumpCorruptSideFiles
(batchId=226)
org.apache.hive.hcatalog.streaming.TestStreaming.testInterleavedTransactionBatchCommits
(batchId=226)
org.apache.hive.hcatalog.streaming.TestStreaming.testMultipleTransactionBatchCommits
(batchId=226)
org.apache.hive.hcatalog.streaming.TestStreaming.testNoBuckets (batchId=226)
org.apache.hive.hcatalog.streaming.TestStreaming.testRemainingTransactions
(batchId=226)
org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchAbort
(batchId=226)
org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchAbortAndCommit
(batchId=226)
org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchCommit_Delimited
(batchId=226)
org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchCommit_DelimitedUGI
(batchId=226)
org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchCommit_Json
(batchId=226)
org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchCommit_Regex
(batchId=226)
org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchCommit_RegexUGI
(batchId=226)
org.apache.hive.hcatalog.streaming.mutate.TestMutations.testMulti (batchId=226)
org.apache.hive.hcatalog.streaming.mutate.TestMutations.testTransactionBatchAbort
(batchId=226)
org.apache.hive.hcatalog.streaming.mutate.TestMutations.testTransactionBatchCommitPartitioned
(batchId=226)
org.apache.hive.hcatalog.streaming.mutate.TestMutations.testTransactionBatchCommitUnpartitioned
(batchId=226)
org.apache.hive.hcatalog.streaming.mutate.TestMutations.testUpdatesAndDeletes
(batchId=226)
org.apache.hive.streaming.TestStreaming.testAddPartition (batchId=369)
org.apache.hive.streaming.TestStreaming.testAllTypesDelimitedWriter
(batchId=369)
org.apache.hive.streaming.TestStreaming.testAllTypesDelimitedWriterInputStream
(batchId=369)
org.apache.hive.streaming.TestStreaming.testAutoRollTransactionBatch
(batchId=369)
org.apache.hive.streaming.TestStreaming.testBucketing (batchId=369)
org.apache.hive.streaming.TestStreaming.testBucketingWhereBucketColIsNotFirstCol
(batchId=369)
org.apache.hive.streaming.TestStreaming.testCommitWithKeyValue (batchId=369)
org.apache.hive.streaming.TestStreaming.testConcurrentTransactionBatchCommits
(batchId=369)
org.apache.hive.streaming.TestStreaming.testErrorHandling (batchId=369)
org.apache.hive.streaming.TestStreaming.testFileDump (batchId=369)
org.apache.hive.streaming.TestStreaming.testFileDumpCorruptDataFiles
(batchId=369)
org.apache.hive.streaming.TestStreaming.testFileDumpCorruptSideFiles
(batchId=369)
org.apache.hive.streaming.TestStreaming.testFileDumpDeltaFilesWithStreamingOptimizations
(batchId=369)
org.apache.hive.streaming.TestStreaming.testFileDumpDeltaFilesWithoutStreamingOptimizations
(batchId=369)
org.apache.hive.streaming.TestStreaming.testInterleavedTransactionBatchCommits
(batchId=369)
org.apache.hive.streaming.TestStreaming.testJsonInputStream (batchId=369)
org.apache.hive.streaming.TestStreaming.testMultipleTransactionBatchCommits
(batchId=369)
org.apache.hive.streaming.TestStreaming.testNoBuckets (batchId=369)
org.apache.hive.streaming.TestStreaming.testRegexInputStream (batchId=369)
org.apache.hive.streaming.TestStreaming.testStreamBucketingMatchesRegularBucketing
(batchId=369)
org.apache.hive.streaming.TestStreaming.testTransactionBatchAbort (batchId=369)
org.apache.hive.streaming.TestStreaming.testTransactionBatchAbortAndCommit
(batchId=369)
org.apache.hive.streaming.TestStreaming.testTransactionBatchCommitDelimited
(batchId=369)
org.apache.hive.streaming.TestStreaming.testTransactionBatchCommitJson
(batchId=369)
org.apache.hive.streaming.TestStreaming.testTransactionBatchCommitRegex
(batchId=369)
org.apache.hive.streaming.TestStreamingDynamicPartitioning.testDPStreamBucketingMatchesRegularBucketing
(batchId=369)
org.apache.hive.streaming.TestStreamingDynamicPartitioning.testDPTwoLevel
(batchId=369)
org.apache.hive.streaming.TestStreamingDynamicPartitioning.testDPTwoLevelMissingPartitionValues
(batchId=369)
org.apache.hive.streaming.TestStreamingDynamicPartitioning.testDPTwoLevelNonStringPartitionColumns
(batchId=369)
org.apache.hive.streaming.TestStreamingDynamicPartitioning.testDynamicPartitioning
(batchId=369)
org.apache.hive.streaming.TestStreamingDynamicPartitioning.testJsonInputStreamDP
(batchId=369)
org.apache.hive.streaming.TestStreamingDynamicPartitioning.testRegexInputStreamDP
(batchId=369)
org.apache.hive.streaming.TestStreamingDynamicPartitioning.testWriteAfterAbort
(batchId=369)
org.apache.hive.streaming.TestStreamingDynamicPartitioning.testWriteAfterClose
(batchId=369)
org.apache.hive.streaming.TestStreamingDynamicPartitioning.testWriteBeforeBegin
(batchId=369)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/21266/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21266/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21266/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 81 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12997682 - PreCommit-HIVE-Build
> Clean up BucketCodec
> --------------------
>
> Key: HIVE-23051
> URL: https://issues.apache.org/jira/browse/HIVE-23051
> Project: Hive
> Issue Type: Improvement
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Major
> Attachments: HIVE-23051.1.patch, HIVE-23051.2.patch,
> HIVE-23051.3.patch
>
>
> A couple of nagging things caught my eye with this class. The first thing:
> {code:java|title=BucketCodec.java}
> int statementId = options.getStatementId() >= 0 ?
> options.getStatementId() : 0;
> assert this.version >=0 && this.version <= MAX_VERSION
> : "Version out of range: " + version;
> if(!(options.getBucketId() >= 0 && options.getBucketId() <=
> MAX_BUCKET_ID)) {
> throw new IllegalArgumentException("bucketId out of range: " +
> options.getBucketId());
> }
> if(!(statementId >= 0 && statementId <= MAX_STATEMENT_ID)) {
> throw new IllegalArgumentException("statementId out of range: " +
> statementId);
> }
> {code}
> {{statementId}} gets capped, if it's less than 0, then it gets rounded up to
> 0. However, it later checks that the {{statementId}} is greater,... which is
> will always be 'true' since it's getting rounded.
> # Remove the rounding behavior.
> # Make better error message
> # Fail-fast in the constructor if the version is invalid
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
