[ 
https://issues.apache.org/jira/browse/HIVE-23051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17067264#comment-17067264
 ] 

Hive QA commented on HIVE-23051:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12997723/HIVE-23051.4.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 18135 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[cbo_query3] 
(batchId=306)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/21270/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21270/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21270/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12997723 - PreCommit-HIVE-Build

> Clean up BucketCodec
> --------------------
>
>                 Key: HIVE-23051
>                 URL: https://issues.apache.org/jira/browse/HIVE-23051
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Major
>         Attachments: HIVE-23051.1.patch, HIVE-23051.2.patch, 
> HIVE-23051.3.patch, HIVE-23051.4.patch
>
>
> A couple of nagging things caught my eye with this class.  The first thing:
> {code:java|title=BucketCodec.java}
>       int statementId = options.getStatementId() >= 0 ? 
> options.getStatementId() : 0;
>       assert this.version >=0 && this.version <= MAX_VERSION
>         : "Version out of range: " + version;
>       if(!(options.getBucketId() >= 0 && options.getBucketId() <= 
> MAX_BUCKET_ID)) {
>         throw new IllegalArgumentException("bucketId out of range: " + 
> options.getBucketId());
>       }
>       if(!(statementId >= 0 && statementId <= MAX_STATEMENT_ID)) {
>         throw new IllegalArgumentException("statementId out of range: " + 
> statementId);
>       }
> {code}
> {{statementId}} gets capped, if it's less than 0, then it gets rounded up to 
> 0.  However, it later checks that the {{statementId}} is greater,... which is 
> will always be 'true' since it's getting rounded.  
> # Remove the rounding behavior.
> # Make better error message
> # Fail-fast in the constructor if the version is invalid



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to