[
https://issues.apache.org/jira/browse/HIVE-23316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102924#comment-17102924
]
Naveen Gangam commented on HIVE-23316:
--------------------------------------
[~mgergely] In my initial implementation I had separate *Operation for the
ManagedLocation but I changed it as I thought there was redundant code and it
was more efficient to reuse the existing classes for the Location. So there was
some thought put into it.
Was it causing an issue that we had to add new classes? If there is no issue, I
think it might be better if we reused the same set of classes.
The check to ensure both of them were not the same was certainly an item I had
in the doc, but couldnt get to in the initial implementation. Thanks
> Add tests to cover database managed location related DDL and fix minor issues
> -----------------------------------------------------------------------------
>
> Key: HIVE-23316
> URL: https://issues.apache.org/jira/browse/HIVE-23316
> Project: Hive
> Issue Type: Bug
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Attachments: HIVE-23316.01.patch
>
>
> Database managed location was recently introduced, but no tests were added to
> cover it. also the following issues were fixed:
> * ALTER DATABASE ... SET MANAGEDLOCATION ... commands were not handled in a
> separate path as it should, as in DDL each command type have their own
> Analyzer, Desc, and Operation class
> * in case of setting the LOCATION or the MANAGEDLOCATION the location was
> not getting qualified as in the CREATE DATABASE command
> * in case of setting the LOCATION or the MANAGEDLOCATION it was not checked
> if this modification makes the two the same
> * some minor checkstyle issues were fixed as well
> Also the DDL documentation was not modified.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
