[ 
https://issues.apache.org/jira/browse/HIVE-23316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17105577#comment-17105577
 ] 

Miklos Gergely commented on HIVE-23316:
---------------------------------------

In my opinion having such a command for setting both location and managed 
location would be very strange, in the sense that all our set commands are for 
setting one thing. Personally I don't see the benefit of it, it would be more 
confusing then useful.

I agree, that having the same syntax for create and alter statements is a good 
thing, but to achieve that we could also have MANAGED LOCATION in two words in 
the create syntax. In general SQL commands are kind of like sentences, and this 
is how it would be grammatically correct.

> Add tests to cover database managed location related DDL and fix minor issues
> -----------------------------------------------------------------------------
>
>                 Key: HIVE-23316
>                 URL: https://issues.apache.org/jira/browse/HIVE-23316
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Miklos Gergely
>            Assignee: Miklos Gergely
>            Priority: Major
>         Attachments: HIVE-23316.01.patch
>
>
> Database managed location was recently introduced, but no tests were added to 
> cover it. also the following issues were fixed:
>  * ALTER DATABASE ... SET MANAGEDLOCATION ... commands were not handled in a 
> separate path as it should, as in DDL each command type have their own 
> Analyzer, Desc, and Operation class
>  * in case of setting the LOCATION or the MANAGEDLOCATION the location was 
> not getting qualified as in the CREATE DATABASE command
>  * in case of setting the LOCATION or the MANAGEDLOCATION it was not checked 
> if this modification makes the two the same
>  * some minor checkstyle issues were fixed as well
> Also the DDL documentation was not modified.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to