[
https://issues.apache.org/jira/browse/HIVE-23514?focusedWorklogId=438791&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-438791
]
ASF GitHub Bot logged work on HIVE-23514:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/May/20 15:59
Start Date: 29/May/20 15:59
Worklog Time Spent: 10m
Work Description: pkumarsinha commented on a change in pull request #1040:
URL: https://github.com/apache/hive/pull/1040#discussion_r432583117
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/AtlasDumpTask.java
##########
@@ -73,7 +74,12 @@ public int execute() {
String entityGuid = checkHiveEntityGuid(atlasRequestBuilder,
atlasReplInfo.getSrcCluster(),
atlasReplInfo.getSrcDB());
long currentModifiedTime = getCurrentTimestamp(atlasReplInfo,
entityGuid);
- dumpAtlasMetaData(atlasRequestBuilder, atlasReplInfo);
+ AtlasDumpLogger replLogger = new
AtlasDumpLogger(atlasReplInfo.getSrcDB(),
+ atlasReplInfo.getStagingDir().toString());
+ replLogger.startLog();
Review comment:
dumpAtlasMetaData is doing actual dump, shouldn't we capture time taken
the complete dump and not just a particular step?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 438791)
Time Spent: 0.5h (was: 20m)
> Add Atlas metadata replication metrics
> --------------------------------------
>
> Key: HIVE-23514
> URL: https://issues.apache.org/jira/browse/HIVE-23514
> Project: Hive
> Issue Type: Task
> Reporter: Pravin Sinha
> Assignee: Pravin Sinha
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-23514.01.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
