[
https://issues.apache.org/jira/browse/HIVE-23514?focusedWorklogId=438800&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-438800
]
ASF GitHub Bot logged work on HIVE-23514:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/May/20 16:04
Start Date: 29/May/20 16:04
Worklog Time Spent: 10m
Work Description: pkumarsinha commented on a change in pull request #1040:
URL: https://github.com/apache/hive/pull/1040#discussion_r432585845
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/AtlasDumpTask.java
##########
@@ -73,7 +74,12 @@ public int execute() {
String entityGuid = checkHiveEntityGuid(atlasRequestBuilder,
atlasReplInfo.getSrcCluster(),
atlasReplInfo.getSrcDB());
long currentModifiedTime = getCurrentTimestamp(atlasReplInfo,
entityGuid);
- dumpAtlasMetaData(atlasRequestBuilder, atlasReplInfo);
+ AtlasDumpLogger replLogger = new
AtlasDumpLogger(atlasReplInfo.getSrcDB(),
+ atlasReplInfo.getStagingDir().toString());
+ replLogger.startLog();
+ long numBytesWritten = dumpAtlasMetaData(atlasRequestBuilder,
atlasReplInfo);
+ LOG.debug("Finished dumping atlas metadata, total:{} bytes written",
numBytesWritten);
+ replLogger.endLog(0L);
Review comment:
We don't need this return value. This is just a workaround for the
mockito bug where it is calling a method of a mocked object. Like the one we
had seen during atlas repl initial patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 438800)
Time Spent: 1h (was: 50m)
> Add Atlas metadata replication metrics
> --------------------------------------
>
> Key: HIVE-23514
> URL: https://issues.apache.org/jira/browse/HIVE-23514
> Project: Hive
> Issue Type: Task
> Reporter: Pravin Sinha
> Assignee: Pravin Sinha
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-23514.01.patch
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
