[
https://issues.apache.org/jira/browse/HIVE-23526?focusedWorklogId=441271&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441271
]
ASF GitHub Bot logged work on HIVE-23526:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jun/20 13:18
Start Date: 04/Jun/20 13:18
Worklog Time Spent: 10m
Work Description: belugabehr commented on a change in pull request #1029:
URL: https://github.com/apache/hive/pull/1029#discussion_r435245485
##########
File path: jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java
##########
@@ -197,6 +198,12 @@ private void closeStatementIfNeeded() throws SQLException {
} catch (SQLException e) {
throw e;
} catch (Exception e) {
+ if (e instanceof TApplicationException && ((TApplicationException)e)
+ .getType() == TApplicationException.BAD_SEQUENCE_ID) {
+ String errorMsg = "Mismatch thrift sequence id, which usually is
caused by an OutOfMemoryError " +
+ "or a SocketTimeoutException, please check the memory status and
previous calls.";
+ throw new SQLException(errorMsg, "08S01", e);
Review comment:
Please do not say 'is usually caused by'. We do not yet know what
"usual" is.
Try something like:
`
Mismatch thrift sequence id. A previous call to the Thrift library failed
and now position within the input stream is lost. Please enable verbose error
logging and check the status of previous calls.
`
##########
File path: jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java
##########
@@ -197,6 +198,12 @@ private void closeStatementIfNeeded() throws SQLException {
} catch (SQLException e) {
throw e;
} catch (Exception e) {
+ if (e instanceof TApplicationException && ((TApplicationException)e)
Review comment:
Please do not use `instanceof` here, just create a new `catch` block for
`TApplicationException` types.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 441271)
Time Spent: 5h (was: 4h 50m)
> Beeline may throw the misleading exception
> ------------------------------------------
>
> Key: HIVE-23526
> URL: https://issues.apache.org/jira/browse/HIVE-23526
> Project: Hive
> Issue Type: Improvement
> Components: Beeline
> Environment: Hive 1.2.2
> Reporter: Zhihua Deng
> Priority: Minor
> Labels: pull-request-available
> Attachments: HIVE-23526.2.patch, HIVE-23526.3.patch,
> HIVE-23526.patch, outofsequence.log
>
> Time Spent: 5h
> Remaining Estimate: 0h
>
> Sometimes we can see 'out of sequence response' message in beeline, for
> example:
> Error: org.apache.thrift.TApplicationException: CloseOperation failed: out of
> sequence response (state=08S01,code=0)
> java.sql.SQLException: org.apache.thrift.TApplicationException:
> CloseOperation failed: out of sequence response
> at
> org.apache.hive.jdbc.HiveStatement.closeClientOperation(HiveStatement.java:198)
> at org.apache.hive.jdbc.HiveStatement.close(HiveStatement.java:217)
> at org.apache.hive.beeline.Commands.execute(Commands.java:891)
> at org.apache.hive.beeline.Commands.sql(Commands.java:713)
> at org.apache.hive.beeline.BeeLine.dispatch(BeeLine.java:976)
> at org.apache.hive.beeline.BeeLine.execute(BeeLine.java:816)
> at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:774)
> at org.apache.hive.beeline.BeeLine.mainWithInputRedirection(BeeLine.java:487)
> at org.apache.hive.beeline.BeeLine.main(BeeLine.java:470)
> and there is no other usage message to figured it out, even with --verbose,
> this makes problem puzzled as beeline does not have concurrency problem on
> underlying thrift transport.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
