[
https://issues.apache.org/jira/browse/HIVE-20890?focusedWorklogId=450332&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-450332
]
ASF GitHub Bot logged work on HIVE-20890:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jun/20 08:47
Start Date: 24/Jun/20 08:47
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #1166:
URL: https://github.com/apache/hive/pull/1166#discussion_r444741159
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
##########
@@ -2994,12 +3005,13 @@ Seems much cleaner if each stmt is identified as a
particular HiveOperation (whi
break;
case DDL_SHARED:
compBuilder.setSharedRead();
- if (!output.isTxnAnalyze()) {
+ if (output.isTxnAnalyze()) {
// Analyze needs txn components to be present, otherwise an aborted
analyze write ID
// might be rolled under the watermark by compactor while stats
written by it are
// still present.
- compBuilder.setOperationType(DataOperationType.NO_TXN);
+ continue;
Review comment:
With using 'continue' we do not execute the code after the case
statement. Is this intentional?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 450332)
Time Spent: 0.5h (was: 20m)
> ACID: Allow whole table ReadLocks to skip all partition locks
> -------------------------------------------------------------
>
> Key: HIVE-20890
> URL: https://issues.apache.org/jira/browse/HIVE-20890
> Project: Hive
> Issue Type: Improvement
> Components: Transactions
> Reporter: Gopal Vijayaraghavan
> Assignee: Denys Kuzmenko
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-20890.1.patch, HIVE-20890.2.patch,
> HIVE-20890.3.patch, HIVE-20890.4.patch, HIVE-20890.5.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> HIVE-19369 proposes adding a EXCL_WRITE lock which does not wait for any
> SHARED_READ locks for read operations - in the presence of that lock, the
> insert overwrite no longer takes an exclusive lock.
> The only exclusive operation will be a schema change or drop table, which
> should take an exclusive lock on the entire table directly.
> {code}
> explain locks select * from tpcds_bin_partitioned_orc_1000.store_sales where
> ss_sold_date_sk=2452626
> +----------------------------------------------------+
> | Explain |
> +----------------------------------------------------+
> | LOCK INFORMATION: |
> | tpcds_bin_partitioned_orc_1000.store_sales -> SHARED_READ |
> | tpcds_bin_partitioned_orc_1000.store_sales.ss_sold_date_sk=2452626 ->
> SHARED_READ |
> +----------------------------------------------------+
> {code}
> So the per-partition SHARED_READ locks are no longer necessary, if the lock
> builder already includes the table-wide SHARED_READ locks.
> The removal of entire partitions is the only part which needs to be taken
> care of within this semantics as row-removal instead of directory removal
> (i.e "drop partition" -> "truncate partition" and have the truncation trigger
> a whole directory cleaner, so that the partition disappears when there are 0
> rows left).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
