[
https://issues.apache.org/jira/browse/HIVE-20890?focusedWorklogId=450380&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-450380
]
ASF GitHub Bot logged work on HIVE-20890:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jun/20 10:36
Start Date: 24/Jun/20 10:36
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on a change in pull request #1166:
URL: https://github.com/apache/hive/pull/1166#discussion_r444802124
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
##########
@@ -2863,6 +2868,9 @@ private static boolean isLockableTable(Table t) {
case TABLE:
t = input.getTable();
+ if (!fullTableLock.contains(t)) {
Review comment:
table equals compares table names, so should be Ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 450380)
Time Spent: 40m (was: 0.5h)
> ACID: Allow whole table ReadLocks to skip all partition locks
> -------------------------------------------------------------
>
> Key: HIVE-20890
> URL: https://issues.apache.org/jira/browse/HIVE-20890
> Project: Hive
> Issue Type: Improvement
> Components: Transactions
> Reporter: Gopal Vijayaraghavan
> Assignee: Denys Kuzmenko
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-20890.1.patch, HIVE-20890.2.patch,
> HIVE-20890.3.patch, HIVE-20890.4.patch, HIVE-20890.5.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> HIVE-19369 proposes adding a EXCL_WRITE lock which does not wait for any
> SHARED_READ locks for read operations - in the presence of that lock, the
> insert overwrite no longer takes an exclusive lock.
> The only exclusive operation will be a schema change or drop table, which
> should take an exclusive lock on the entire table directly.
> {code}
> explain locks select * from tpcds_bin_partitioned_orc_1000.store_sales where
> ss_sold_date_sk=2452626
> +----------------------------------------------------+
> | Explain |
> +----------------------------------------------------+
> | LOCK INFORMATION: |
> | tpcds_bin_partitioned_orc_1000.store_sales -> SHARED_READ |
> | tpcds_bin_partitioned_orc_1000.store_sales.ss_sold_date_sk=2452626 ->
> SHARED_READ |
> +----------------------------------------------------+
> {code}
> So the per-partition SHARED_READ locks are no longer necessary, if the lock
> builder already includes the table-wide SHARED_READ locks.
> The removal of entire partitions is the only part which needs to be taken
> care of within this semantics as row-removal instead of directory removal
> (i.e "drop partition" -> "truncate partition" and have the truncation trigger
> a whole directory cleaner, so that the partition disappears when there are 0
> rows left).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
