[ 
https://issues.apache.org/jira/browse/HIVE-11903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906981#comment-14906981
 ] 

Yongzhi Chen commented on HIVE-11903:
-------------------------------------

[~szehon], thanks for review the patch. For the suggestions:
1. I will remove JDBC zoopkeeper.
2. Just check the patch everywhere, it seems all has null checks. A little bit 
confused.
I will add metrics based on lock-type.
3. For I already add the test of number of locks for zookeeper locks, do you 
need add one for metastore_hive_locks ? 
Thanks 


> Add zookeeper metrics to HS2
> ----------------------------
>
>                 Key: HIVE-11903
>                 URL: https://issues.apache.org/jira/browse/HIVE-11903
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Diagnosability
>            Reporter: Szehon Ho
>            Assignee: Yongzhi Chen
>             Fix For: 1.3.0, 2.0.0
>
>         Attachments: HIVE-11903.1.patch
>
>
> Potential metrics are active zookeeper connections, locks taken by type, etc. 
>  Can refine as we go along.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to