[
https://issues.apache.org/jira/browse/HIVE-11903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933701#comment-14933701
]
Szehon Ho commented on HIVE-11903:
----------------------------------
Sorry for late reply. I hadn't followed that change closely, thanks for
letting me know.
I see its a singleton, but I still don't suppose always saying 1 is not that
useful. For example would it detect if the client is disconnected? We might
need to plug in the event framework for that, what do you think? I took a
look, it might be useful to have something like what Curator does in
"ConnectionState.checkState()", in that class they keep track of certain events
in their tracer logs that we could potentially plug into metrics.
One option, as this might be more involved than initially anticipated, is we
can repurpose this JIRA to checkin the existing changes about number of locks.
This is very useful already, and maybe we can remove the zookeeper stuff for
now and tackle it in another JIRA?
> Add zookeeper metrics to HS2
> ----------------------------
>
> Key: HIVE-11903
> URL: https://issues.apache.org/jira/browse/HIVE-11903
> Project: Hive
> Issue Type: Sub-task
> Components: Diagnosability
> Reporter: Szehon Ho
> Assignee: Yongzhi Chen
> Fix For: 1.3.0, 2.0.0
>
> Attachments: HIVE-11903.1.patch, HIVE-11903.2.patch
>
>
> Potential metrics are active zookeeper connections, locks taken by type, etc.
> Can refine as we go along.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
