[
https://issues.apache.org/jira/browse/HIVE-24561?focusedWorklogId=527339&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-527339
]
ASF GitHub Bot logged work on HIVE-24561:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Dec/20 20:02
Start Date: 22/Dec/20 20:02
Worklog Time Spent: 10m
Work Description: vihangk1 opened a new pull request #1808:
URL: https://github.com/apache/hive/pull/1808
### What changes were proposed in this pull request?
This PR modifies the test TestCachedStoreUpdateUsingEvents to not use
"file:/tmp" which is error prone since clean up method can delete all the files
in /tmp. Also fixes a harmless NPE which unnecessarily spams the log file.
### Why are the changes needed?
I observed this test to be failing on a unrelated PR. I am hoping that these
changes will help remove any flakiness if present.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Ran the test locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 527339)
Remaining Estimate: 0h
Time Spent: 10m
> Deflake TestCachedStoreUpdateUsingEvents
> ----------------------------------------
>
> Key: HIVE-24561
> URL: https://issues.apache.org/jira/browse/HIVE-24561
> Project: Hive
> Issue Type: Test
> Reporter: Vihang Karajgaonkar
> Assignee: Vihang Karajgaonkar
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> TestCachedStoreUpdateUsingEvents seems to use "file:/tmp" as the table and
> database directory. The cleanUp method will clean all the sub-directories
> directories in /tmp which can be error prone.
> Also noticed that I see a lot NPEs from
> {{SharedCache#getMemorySizeEstimator}} because the {{sizeEstimators}} field
> is null. We should add a null check for that field.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
