[
https://issues.apache.org/jira/browse/HIVE-24561?focusedWorklogId=527361&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-527361
]
ASF GitHub Bot logged work on HIVE-24561:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Dec/20 20:52
Start Date: 22/Dec/20 20:52
Worklog Time Spent: 10m
Work Description: kishendas commented on a change in pull request #1808:
URL: https://github.com/apache/hive/pull/1808#discussion_r547501638
##########
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/cache/TestCachedStoreUpdateUsingEvents.java
##########
@@ -82,9 +84,9 @@ public void setUp() throws Exception {
HiveMetaStore.HMSHandler.createDefaultCatalog(rawStore, new
Warehouse(conf));
}
- private Database createTestDb(String dbName, String dbOwner) {
+ private Database createTestDb(String dbName, String dbOwner) throws
IOException {
String dbDescription = dbName;
- String dbLocation = "file:/tmp";
+ String dbLocation = Files.createTempDirectory(dbName).toString();
Review comment:
Even the dbName can be same across multiple tests, which can get cleaned
up. Would it be a good idea to use the current timestamp or generate a random
number and use that for the temporary directory ?
##########
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/cache/TestCachedStoreUpdateUsingEvents.java
##########
@@ -94,8 +96,9 @@ private Database createTestDb(String dbName, String dbOwner) {
}
private Table createTestTblParam(String dbName, String tblName, String
tblOwner,
- List<FieldSchema> cols, List<FieldSchema>
ptnCols, Map<String, String> tblParams) {
- String serdeLocation = "file:/tmp";
+ List<FieldSchema> cols, List<FieldSchema>
ptnCols, Map<String, String> tblParams)
+ throws IOException {
+ String serdeLocation = Files.createTempDirectory(dbName + "_" +
tblName).toString();
Review comment:
Even the dbName and tblName can be same across multiple tests, which can
get cleaned up. Would it be a good idea to use the current timestamp or
generate a random number and use that for the temporary directory ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 527361)
Time Spent: 20m (was: 10m)
> Deflake TestCachedStoreUpdateUsingEvents
> ----------------------------------------
>
> Key: HIVE-24561
> URL: https://issues.apache.org/jira/browse/HIVE-24561
> Project: Hive
> Issue Type: Test
> Reporter: Vihang Karajgaonkar
> Assignee: Vihang Karajgaonkar
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> TestCachedStoreUpdateUsingEvents seems to use "file:/tmp" as the table and
> database directory. The cleanUp method will clean all the sub-directories
> directories in /tmp which can be error prone.
> Also noticed that I see a lot NPEs from
> {{SharedCache#getMemorySizeEstimator}} because the {{sizeEstimators}} field
> is null. We should add a null check for that field.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
