[
https://issues.apache.org/jira/browse/HIVE-24673?focusedWorklogId=542818&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542818
]
ASF GitHub Bot logged work on HIVE-24673:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jan/21 13:12
Start Date: 27/Jan/21 13:12
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on a change in pull request #1902:
URL: https://github.com/apache/hive/pull/1902#discussion_r565284065
##########
File path: ql/src/test/queries/clientnegative/subquery_scalar_corr_multi_rows.q
##########
@@ -1,3 +1,4 @@
+--! qt:disabled:See HIVE-24595
Review comment:
do these tests become unstable after this patch?
if not then disabling tests should be done in a separate commit
##########
File path:
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java
##########
@@ -348,13 +348,13 @@ public CompareCliConfig() {
}
}
- public static class NegativeCliConfig extends AbstractCliConfig {
- public NegativeCliConfig() {
+ public static class NegativeLlapLocalCliConfig extends AbstractCliConfig {
Review comment:
I know that during the development of this patch it seemed more straight
forward to add a new negative driver and migrate stuff into that new driver -
but right now I wonder what's the benefit of removing the old and creating a
new one with "llap" in its name - the new driver could handle all the old cases
(the ones which are not handled are being removed...)
what do you think?
##########
File path: ql/src/test/results/clientnegative/msck_repair_3.q.out
##########
@@ -16,7 +16,5 @@ PREHOOK: Output: default@repairtable
POSTHOOK: query: MSCK TABLE repairtable
POSTHOOK: type: MSCK
POSTHOOK: Output: default@repairtable
-PREHOOK: query: MSCK TABLE default.repairtable
-PREHOOK: type: MSCK
-PREHOOK: Output: default@repairtable
-FAILED: Execution Error, return code 1 from
org.apache.hadoop.hive.ql.ddl.DDLTask
+#### A masked pattern was here ####
+Query returned non-zero code: -1, cause: null
Review comment:
this seems to be a different error
##########
File path: ql/src/test/results/clientnegative/msck_repair_2.q.out
##########
@@ -16,7 +16,5 @@ PREHOOK: Output: default@repairtable
POSTHOOK: query: MSCK TABLE repairtable
POSTHOOK: type: MSCK
POSTHOOK: Output: default@repairtable
-PREHOOK: query: MSCK TABLE default.repairtable
-PREHOOK: type: MSCK
-PREHOOK: Output: default@repairtable
-FAILED: Execution Error, return code 1 from
org.apache.hadoop.hive.ql.ddl.DDLTask
+#### A masked pattern was here ####
+Query returned non-zero code: -1, cause: null
Review comment:
this seems to be a different error
##########
File path: ql/src/test/results/clientnegative/avro_non_nullable_union.q.out
##########
@@ -34,5 +34,39 @@ PREHOOK: query: INSERT OVERWRITE TABLE
union_non_nullable_test_avro SELECT * FRO
PREHOOK: type: QUERY
PREHOOK: Input: default@union_nullable_test_text
PREHOOK: Output: default@union_non_nullable_test_avro
+Status: Failed
+Vertex failed, vertexName=Map 1, vertexId=vertex_#ID#, diagnostics=[Task
failed, taskId=task_#ID#, diagnostics=[TaskAttempt 0 failed, info=[Error: Error
while running task ( failure ) : attempt_#ID#:java.lang.RuntimeException:
java.lang.RuntimeException: Hive Runtime Error while closing operators
#### A masked pattern was here ####
-FAILED: Execution Error, return code 2 from
org.apache.hadoop.hive.ql.exec.mr.MapRedTask
+Caused by: java.lang.RuntimeException: Hive Runtime Error while closing
operators
+#### A masked pattern was here ####
+Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: Avro could not
validate record against schema (record = {"id": 3, "value": null}) (schema =
{"type":"record","name":"nullable","fields":[{"name":"id","type":"int"},{"name":"value","type":["int","double"]}]})
+#### A masked pattern was here ####
+Caused by: Avro could not validate record against schema (record = {"id": 3,
"value": null}) (schema =
{"type":"record","name":"nullable","fields":[{"name":"id","type":"int"},{"name":"value","type":["int","double"]}]})
Review comment:
this new exception surely contains more information ; but it's also
repeats the same thing a few times - it would be great to improve on this
(probably in a separate ticket)
##########
File path: ql/src/test/results/clientnegative/ct_noperm_loc.q.out
##########
@@ -1,11 +1 @@
-PREHOOK: query: create table foo0(id int) location 'hdfs://### HDFS PATH ###'
-PREHOOK: type: CREATETABLE
-PREHOOK: Input: hdfs://### HDFS PATH ###
-PREHOOK: Output: database:default
-PREHOOK: Output: default@foo0
-POSTHOOK: query: create table foo0(id int) location 'hdfs://### HDFS PATH ###'
Review comment:
I wonder why we have lost these messages from the q.out - the q file
didn't changed at all; the other tests have PREHOOK/POSTHOOK messages just like
before; does this have a simple explanations?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 542818)
Time Spent: 1.5h (was: 1h 20m)
> Migrate NegativeCliDriver and NegativeMinimrCliDriver to llap
> -------------------------------------------------------------
>
> Key: HIVE-24673
> URL: https://issues.apache.org/jira/browse/HIVE-24673
> Project: Hive
> Issue Type: Improvement
> Reporter: Mustafa İman
> Assignee: Mustafa İman
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> These test drivers should run on llap. Otherwise we can run into situations
> where certain queries correctly fail on MapReduce but not on Tez.
> Also, it is better if negative cli drivers does not mask "Caused by" lines in
> test output. Otherwise, a query may start to fail for other reasons than the
> expected one and we do not realize it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
