[
https://issues.apache.org/jira/browse/HIVE-24673?focusedWorklogId=543006&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-543006
]
ASF GitHub Bot logged work on HIVE-24673:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jan/21 18:59
Start Date: 27/Jan/21 18:59
Worklog Time Spent: 10m
Work Description: mustafaiman commented on a change in pull request #1902:
URL: https://github.com/apache/hive/pull/1902#discussion_r565557991
##########
File path:
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java
##########
@@ -348,13 +348,13 @@ public CompareCliConfig() {
}
}
- public static class NegativeCliConfig extends AbstractCliConfig {
- public NegativeCliConfig() {
+ public static class NegativeLlapLocalCliConfig extends AbstractCliConfig {
Review comment:
I did not understand your point. I just renamed the old drivers. I had
to rename NegativeMinimr because it has "mr" in it. I admittedly did not have
to rename NegativeCliDriver. I changed that one to make the naming consistent
with other drivers (MiniLlapCliDriver and MiniLlapLocalCliDriver). Also, all 4
llap drivers use the same config directory. It is easier to identify they all
use the same runtime with similar names.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 543006)
Time Spent: 2h (was: 1h 50m)
> Migrate NegativeCliDriver and NegativeMinimrCliDriver to llap
> -------------------------------------------------------------
>
> Key: HIVE-24673
> URL: https://issues.apache.org/jira/browse/HIVE-24673
> Project: Hive
> Issue Type: Improvement
> Reporter: Mustafa İman
> Assignee: Mustafa İman
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> These test drivers should run on llap. Otherwise we can run into situations
> where certain queries correctly fail on MapReduce but not on Tez.
> Also, it is better if negative cli drivers does not mask "Caused by" lines in
> test output. Otherwise, a query may start to fail for other reasons than the
> expected one and we do not realize it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
