[
https://issues.apache.org/jira/browse/HIVE-24346?focusedWorklogId=542954&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542954
]
ASF GitHub Bot logged work on HIVE-24346:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jan/21 17:40
Start Date: 27/Jan/21 17:40
Worklog Time Spent: 10m
Work Description: mustafaiman commented on pull request #1733:
URL: https://github.com/apache/hive/pull/1733#issuecomment-768454416
@zeroflag
I see getAllStoredProcedures and dropPackage of RawStore are used in
drop_database_core. These are internal to metastore. I was referring to
getAllStoredProcedures and dropPackage of HiveMetastoreClient. Those metastore
rpc's are not used by Hive at all. Are they there for some other client to use
it? On a related note, how does a use drop a package?
The problem with InMemoryPackageRegistry and `packages` hashmap is that once
`packages` have the package we do not ever need to lookup
InMemoryPackageRegistry again. At this point InMemoryPackageRegistry looks like
a memory leak. Two structures keep the same info in different forms: source and
compiled. The thing is we do not need source once we have the compiled one. So
it leads me to think that InMemoryPackageRegistry is just a compilation of
utility methods to compile the source but it also keeps the source forever
unnecessarily.
Also there are no new tests in this patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 542954)
Time Spent: 1h 10m (was: 1h)
> Store HPL/SQL packages into HMS
> -------------------------------
>
> Key: HIVE-24346
> URL: https://issues.apache.org/jira/browse/HIVE-24346
> Project: Hive
> Issue Type: Sub-task
> Components: hpl/sql, Metastore
> Reporter: Attila Magyar
> Assignee: Attila Magyar
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
