[
https://issues.apache.org/jira/browse/HIVE-24346?focusedWorklogId=543068&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-543068
]
ASF GitHub Bot logged work on HIVE-24346:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jan/21 20:39
Start Date: 27/Jan/21 20:39
Worklog Time Spent: 10m
Work Description: zeroflag commented on pull request #1733:
URL: https://github.com/apache/hive/pull/1733#issuecomment-768562536
@mustafaiman, good point, from the outside they're not called only from HMS.
There is no drop syntax in the grammar for dropping packages but that need to
be added later on and that will make use of those methods.
Regarding the InMemoryPackageRegistry I don't see this as a huge problem as
this is only needed for CLI mode where HMS is not used at all. This mode will
likely be dropped anyway it's only for having some transition between the old
mechanism and the new HMS backed storage. I didn't want to remove this mode
right away as some existing tests rely on this mode.
The new tests are in TestObjectStore.java and TestHplSqlViaBeeLine.java. On
the HPLSQL level no new language features were added only an implementation
details changed therefore no new tests in that project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 543068)
Time Spent: 1h 20m (was: 1h 10m)
> Store HPL/SQL packages into HMS
> -------------------------------
>
> Key: HIVE-24346
> URL: https://issues.apache.org/jira/browse/HIVE-24346
> Project: Hive
> Issue Type: Sub-task
> Components: hpl/sql, Metastore
> Reporter: Attila Magyar
> Assignee: Attila Magyar
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
