[
https://issues.apache.org/jira/browse/HIVE-24346?focusedWorklogId=550201&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-550201
]
ASF GitHub Bot logged work on HIVE-24346:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Feb/21 12:07
Start Date: 09/Feb/21 12:07
Worklog Time Spent: 10m
Work Description: zeroflag commented on a change in pull request #1733:
URL: https://github.com/apache/hive/pull/1733#discussion_r572831541
##########
File path: hplsql/src/main/java/org/apache/hive/hplsql/Exec.java
##########
@@ -1633,11 +1687,11 @@ public Integer
visitExpr_cursor_attribute(HplsqlParser.Expr_cursor_attributeCont
*/
@Override
public Integer visitExpr_func(HplsqlParser.Expr_funcContext ctx) {
- String name = ctx.ident().getText();
+ String name = ctx.ident().getText();
if (exec.buildSql) {
exec.execSql(name, ctx.expr_func_params());
- }
- else {
+ } else {
+ name = name.toUpperCase();
Review comment:
I didn't find a good parser level solution for this. I'll revisit it in
the next issue HIVE-24315 which is dedicated for improvements and bug fixes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 550201)
Time Spent: 5h 40m (was: 5.5h)
> Store HPL/SQL packages into HMS
> -------------------------------
>
> Key: HIVE-24346
> URL: https://issues.apache.org/jira/browse/HIVE-24346
> Project: Hive
> Issue Type: Sub-task
> Components: hpl/sql, Metastore
> Reporter: Attila Magyar
> Assignee: Attila Magyar
> Priority: Major
> Labels: pull-request-available
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
