[
https://issues.apache.org/jira/browse/HIVE-24346?focusedWorklogId=554688&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-554688
]
ASF GitHub Bot logged work on HIVE-24346:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Feb/21 10:07
Start Date: 19/Feb/21 10:07
Worklog Time Spent: 10m
Work Description: zeroflag commented on a change in pull request #1733:
URL: https://github.com/apache/hive/pull/1733#discussion_r579069892
##########
File path: hplsql/src/main/java/org/apache/hive/hplsql/Exec.java
##########
@@ -328,16 +334,16 @@ public String callStackPop() {
*/
public Var findVariable(String name) {
Var var;
- String name1 = name;
+ String name1 = name.toUpperCase();
String name1a = null;
String name2 = null;
Scope cur = exec.currentScope;
Package pack;
Package packCallContext = exec.getPackageCallContext();
ArrayList<String> qualified = exec.meta.splitIdentifier(name);
if (qualified != null) {
- name1 = qualified.get(0);
- name2 = qualified.get(1);
+ name1 = qualified.get(0).toUpperCase();
Review comment:
splitIdentifier() is also used with table names and column names, I
think it's better to leave column and table names alone as it would modify the
HiveQL queries and it's rather Hive's territory than HPLSQL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 554688)
Time Spent: 6h 10m (was: 6h)
> Store HPL/SQL packages into HMS
> -------------------------------
>
> Key: HIVE-24346
> URL: https://issues.apache.org/jira/browse/HIVE-24346
> Project: Hive
> Issue Type: Sub-task
> Components: hpl/sql, Metastore
> Reporter: Attila Magyar
> Assignee: Attila Magyar
> Priority: Major
> Labels: pull-request-available
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
