[
https://issues.apache.org/jira/browse/HIVE-24727?focusedWorklogId=568183&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-568183
]
ASF GitHub Bot logged work on HIVE-24727:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Mar/21 08:58
Start Date: 18/Mar/21 08:58
Worklog Time Spent: 10m
Work Description: asinkovits commented on a change in pull request #2066:
URL: https://github.com/apache/hive/pull/2066#discussion_r596663012
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapProtocolServerImpl.java
##########
@@ -369,6 +372,13 @@ public GetTokenResponseProto
getDelegationToken(RpcController controller,
return responseProtoBuilder.build();
}
+ @Override
+ public GetCacheContentResponseProto getCacheContent(RpcController controller,
+ GetCacheContentRequestProto request) {
+ CacheEntryList entries = LlapProxy.getIo().fetchCachedMetadata();
Review comment:
For the sake of con consistency, i think its better to return an empty
response rather than a null. All rpc calls in the api do this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 568183)
Time Spent: 40m (was: 0.5h)
> Cache hydration api in llap proto
> ---------------------------------
>
> Key: HIVE-24727
> URL: https://issues.apache.org/jira/browse/HIVE-24727
> Project: Hive
> Issue Type: Sub-task
> Reporter: Antal Sinkovits
> Assignee: Antal Sinkovits
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
