[ 
https://issues.apache.org/jira/browse/HIVE-24727?focusedWorklogId=568187&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-568187
 ]

ASF GitHub Bot logged work on HIVE-24727:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Mar/21 09:13
            Start Date: 18/Mar/21 09:13
    Worklog Time Spent: 10m 
      Work Description: asinkovits commented on a change in pull request #2066:
URL: https://github.com/apache/hive/pull/2066#discussion_r596673725



##########
File path: 
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java
##########
@@ -18,24 +18,36 @@
 
 package org.apache.hadoop.hive.llap.io.api.impl;
 
+import java.io.ByteArrayInputStream;
+import java.io.ByteArrayOutputStream;
+import java.io.DataInput;
+import java.io.DataInputStream;
+import java.io.DataOutputStream;
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.Arrays;
+import java.util.Comparator;
+import java.util.HashMap;
 import java.util.List;
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.LinkedBlockingQueue;
 import java.util.concurrent.TimeUnit;
 import java.util.function.Predicate;
+import java.util.stream.Collectors;
 
 import javax.management.ObjectName;
 
+import com.google.protobuf.ByteString;
 import org.apache.hadoop.fs.Path;
 import org.apache.hadoop.hive.common.io.CacheTag;
 import org.apache.hadoop.hive.llap.ProactiveEviction;
 import org.apache.hadoop.hive.llap.cache.MemoryLimitedPathCache;
 import org.apache.hadoop.hive.llap.cache.PathCache;
+import org.apache.hadoop.hive.llap.cache.LlapCacheableBuffer;
 import org.apache.hadoop.hive.llap.cache.ProactiveEvictingCachePolicy;
 import org.apache.hadoop.hive.llap.daemon.impl.StatsRecordingThreadPool;
+import org.apache.hadoop.hive.llap.io.encoded.LlapOrcCacheLoader;
+import org.apache.hadoop.hive.ql.io.SyntheticFileId;

Review comment:
       Good catch. Missed removing the imports.
   The LlapCacheMetadataSerializer solely purpose is to decouple the logic, and 
make it more testable. It's in the same package as LlapIoImpl, so no import is 
required.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 568187)
    Time Spent: 50m  (was: 40m)

> Cache hydration api in llap proto
> ---------------------------------
>
>                 Key: HIVE-24727
>                 URL: https://issues.apache.org/jira/browse/HIVE-24727
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Antal Sinkovits
>            Assignee: Antal Sinkovits
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to