[
https://issues.apache.org/jira/browse/HIVE-25200?focusedWorklogId=607404&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-607404
]
ASF GitHub Bot logged work on HIVE-25200:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jun/21 05:47
Start Date: 05/Jun/21 05:47
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #2351:
URL: https://github.com/apache/hive/pull/2351#discussion_r645946749
##########
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
##########
@@ -265,9 +287,12 @@ public void
commitAlterTable(org.apache.hadoop.hive.metastore.api.Table hmsTable
HiveTableUtil.importFiles(preAlterTableProperties.tableLocation,
preAlterTableProperties.format,
partitionSpecProxy, preAlterTableProperties.partitionKeys,
catalogProperties, conf);
} else {
- Map<String, String> contextProperties = context.getProperties();
- if (contextProperties.containsKey(ALTER_TABLE_OPERATION_TYPE) &&
-
allowedAlterTypes.contains(contextProperties.get(ALTER_TABLE_OPERATION_TYPE))) {
+ if (isMatchingAlterOp(AlterTableType.ADDCOLS, context) && updateSchema
!= null) {
Review comment:
Wouldn't it be cleaner to just get the operation in the beginning and
use that through the method. I find it confusing that we call
`isMatchingAlterOp` all the time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 607404)
Time Spent: 40m (was: 0.5h)
> Alter table add columns support for Iceberg tables
> --------------------------------------------------
>
> Key: HIVE-25200
> URL: https://issues.apache.org/jira/browse/HIVE-25200
> Project: Hive
> Issue Type: Improvement
> Reporter: Ádám Szita
> Assignee: Ádám Szita
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Since Iceberg counts as being a non-native Hive table, addColumn operation
> needs to be implemented by the help of Hive meta hooks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
